From 7583ffbb600efbe999ac124ee9395d12980e6709 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 16 Jun 2020 01:17:29 -0500 Subject: [PATCH] mb/google/hatch: fix variants' selection of CHROMEOS_DSM_CALIB CHROMEOS_DSM_CALIB requires/selects CHROMEOS, so only select if CHROMEOS already selected, otherwise building for non-ChromeOS targets fails. Test: build HELIOS for non-ChromeOS target (Tianocore payload) Change-Id: Ic0fd3b0a0efbc5a1f6896eb379569a55cb0f67f8 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/42414 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Furquan Shaikh --- src/mainboard/google/hatch/Kconfig.name | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 0688e09d79..7359911047 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -48,7 +48,7 @@ config BOARD_GOOGLE_KINDRED config BOARD_GOOGLE_HELIOS bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 config BOARD_GOOGLE_MUSHU @@ -58,13 +58,13 @@ config BOARD_GOOGLE_MUSHU config BOARD_GOOGLE_PALKIA bool "-> Palkia" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 config BOARD_GOOGLE_NIGHTFURY bool "-> Nightfury" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_MAX98390 config BOARD_GOOGLE_NOIBAT @@ -79,7 +79,7 @@ config BOARD_GOOGLE_PUFF config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 config BOARD_GOOGLE_STRYKE