GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google boards: Do not hardcode location of spd.bin 

spd.bin can reside anywhere in CBFS, and we only use CBFS APIs to
access and read it. As such, there is no need to hardcode it, and it
can collide with mrc.bin or mrc.cache on some boards. Do not use a
specific position for spd.bin, but instead let cbfstool find the
optimal placement.

Change-Id: I496094d3c0de708813494095b7ac4be8addb4112
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/5210
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Alexandru Gagniuc 2014-02-12 15:54:47 -06:00
parent 82e7d956ef
commit 76e25b66ae
8 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/bolt/Makefile.inc
View File

@ -43,4 +43,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffec000

1
src/mainboard/google/falco/Makefile.inc
View File

@ -48,4 +48,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffec000

1
src/mainboard/google/link/Makefile.inc
View File

@ -42,4 +42,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffec000

1
src/mainboard/google/peppy/Makefile.inc
View File

@ -49,4 +49,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffec000

4
src/mainboard/google/rambi/Kconfig
View File

@ -32,8 +32,4 @@ config HAVE_ME_BIN
bool bool
default n default n
config SPD_CBFS_ADDRESS
hex "Location of SPD in CBFS"
default 0xfffec000
endif # BOARD_INTEL_BAYLEYBAY endif # BOARD_INTEL_BAYLEYBAY

1
src/mainboard/google/rambi/spd/Makefile.inc
View File

@ -43,4 +43,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := $(CONFIG_SPD_CBFS_ADDRESS)

1
src/mainboard/google/slippy/Makefile.inc
View File

@ -45,4 +45,3 @@ $(SPD_BIN): $(SPD_DEPS)
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffec000

1
src/mainboard/samsung/lumpy/Makefile.inc
View File

@ -28,4 +28,3 @@ $(SPD_BIN):
cbfs-files-y += spd.bin cbfs-files-y += spd.bin
spd.bin-file := $(SPD_BIN) spd.bin-file := $(SPD_BIN)
spd.bin-type := 0xab spd.bin-type := 0xab
spd.bin-position := 0xfffdc000