GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reland "mb/google/zork: Revert Don't expose reset GPIO for touchscreen to OS" 

This reverts commit 81066b7ce7.

Reason for revert: The hang observed when not exposing the reset GPIOs was root caused to zork sharing the same I2C bus between touchscreen and touchpad and interleaving of messages during probe which resulted in incorrect information returned back by touchscreen firmware. Exposing the reset GPIO changed the timing of probe and hence helped workaround the hang issue. The touchscreen driver is now fixed to perform I2C transactions in a single transfer and so the hang is no longer observed when reset GPIO isn't exposed.

BUG=b:162596241
BRANCH=zork

Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: Ica11c33d542dd2324bb0b8905c5de06047cee301
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44752
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh 2020-08-24 18:37:15 +00:00
parent 14025bd5cc
commit 774073dd0f
4 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/zork/variants/berknip/overridetree.cb
View File

@ -73,6 +73,7 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic

1
src/mainboard/google/zork/variants/dalboz/overridetree.cb
View File

@ -53,6 +53,7 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic

1
src/mainboard/google/zork/variants/ezkinil/overridetree.cb
View File

@ -74,6 +74,7 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid

1
src/mainboard/google/zork/variants/trembyle/overridetree.cb
View File

@ -76,6 +76,7 @@ chip soc/amd/picasso
register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
register "stop_off_delay_ms" = "1" register "stop_off_delay_ms" = "1"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic