GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/kano: Prevent camera LED blinking during boot 

Camera LED blinks as sensor is being probed during kernel boot,
which misleads user to belive camera has been turned on.

Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips
initial probe during kernel boot and prevent privacy LED blink.

BUG=b:214155527
TEST=Build and boot Kano to OS. Verify entries in SSDT and monitor LED
during boot.

Signed-off-by: Jim Lai <jim.lai@intel.com>
Change-Id: I92f1e88d0fcce49660a95d4402c8c4161e320168
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61109
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jim Lai 2022-01-13 15:22:38 +08:00 committed by Felix Held
parent dc0eb656eb
commit 77426ffa6c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/brya/variants/kano/overridetree.cb
View File

@ -368,6 +368,7 @@ chip soc/intel/alderlake
register "num_freq_entries" = "1" register "num_freq_entries" = "1"
register "link_freq[0]" = "360 * MHz" register "link_freq[0]" = "360 * MHz"
register "remote_name" = ""IPU0"" register "remote_name" = ""IPU0""
register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"
#Controls #Controls
register "clk_panel.clks[0].clknum" = "IMGCLKOUT_3" register "clk_panel.clks[0].clknum" = "IMGCLKOUT_3"
@ -400,8 +401,6 @@ chip soc/intel/alderlake
register "chip_name" = ""AT24 EEPROM"" register "chip_name" = ""AT24 EEPROM""
register "device_type" = "INTEL_ACPI_CAMERA_NVM" register "device_type" = "INTEL_ACPI_CAMERA_NVM"
register "pr0" = ""\\_SB.PCI0.I2C2.CAM0.PRIC""
register "nvm_size" = "0x2000" register "nvm_size" = "0x2000"
register "nvm_pagesize" = "1" register "nvm_pagesize" = "1"
register "nvm_readonly" = "1" register "nvm_readonly" = "1"