From 77562cf95e8b5911919fc346949bc17eb32d8b87 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 7 Dec 2020 01:05:51 +0100 Subject: [PATCH] mb/siemens/chili/base: Fix state of PCI devices MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The PCI devices P2SB and PMC are hidden by the FSP and cannot be unhidden, because the FSP locks their configuration. Thus, setting them to `on` is not correct. Therefore, set their state to hidden. Change-Id: Ib7c019cd7f389b2e487829e5550cc236ee5645b7 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/48388 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) --- src/mainboard/siemens/chili/variants/base/devicetree.cb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/siemens/chili/variants/base/devicetree.cb b/src/mainboard/siemens/chili/variants/base/devicetree.cb index 6bdec658cf..949380177b 100644 --- a/src/mainboard/siemens/chili/variants/base/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/base/devicetree.cb @@ -120,8 +120,8 @@ chip soc/intel/cannonlake device pnp 0c31.0 on end end end - device pci 1f.1 on end # P2SB - device pci 1f.2 on end # Power Management Controller + device pci 1f.1 hidden end # P2SB + device pci 1f.2 hidden end # Power Management Controller device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI