soc/intel: Refactor do_global_reset() function

List of changes:
1. Rename do_global_reset() to force_global_reset()
2. Make force_global_reset() function static
3. Implement force_global_reset() into common/reset.c to avoid
dedicated SoC implementation
4. Remove redundant force_global_reset() implementation from
dedicated SoC
5. Make direct call to global_reset() from cse_lite.c
7. Drop CONFIG_HAVE_CF9_RESET_PREPARE Kconfig from APL SoC due
to common reset (soc/intel/common/reset.c) code migration
8. Remove unused function send_global_reset() from SKL me.c due
to common reset code migration
9. Delete heci.c from APL SoC as unused

Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Change-Id: I1c5dc8d5606ef28ffaed4a64d90f470ae1ffc2a6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45541
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>

src/soc/intel/alderlake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <fsp/util.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/apollolake/Kconfig

@@ -99,7 +99,6 @@ config CPU_SPECIFIC_OPTIONS
 	select UDK_2015_BINDING if !SOC_INTEL_GEMINILAKE
 	select UDK_2017_BINDING if SOC_INTEL_GEMINILAKE
 	select SOC_INTEL_COMMON_RESET
-	select HAVE_CF9_RESET_PREPARE
 	select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
 	select HAVE_FSP_GOP
 	select HAVE_FSP_LOGO_SUPPORT

src/soc/intel/apollolake/Makefile.inc

@@ -12,7 +12,6 @@ subdirs-y += ../../../cpu/x86/cache
 bootblock-y += bootblock/bootblock.c
 bootblock-$(CONFIG_FSP_CAR) += fspcar.c
 bootblock-y += car.c
-bootblock-y += heci.c
 bootblock-y += gspi.c
 bootblock-y += i2c.c
 bootblock-y += lpc.c
@@ -26,7 +25,6 @@ romstage-y += ../../../cpu/intel/car/romstage.c
 romstage-y += romstage.c
 romstage-y += report_platform.c
 romstage-y += gspi.c
-romstage-y += heci.c
 romstage-y += i2c.c
 romstage-y += uart.c
 romstage-y += meminit.c
@@ -56,7 +54,6 @@ ramstage-y += cse.c
 ramstage-y += elog.c
 ramstage-y += graphics.c
 ramstage-y += gspi.c
-ramstage-y += heci.c
 ramstage-y += i2c.c
 ramstage-y += lpc.c
 ramstage-y += mmap_boot.c
@@ -75,7 +72,6 @@ ramstage-y += xhci.c
 postcar-y += mmap_boot.c
 postcar-y += spi.c
 postcar-y += i2c.c
-postcar-y += heci.c
 postcar-y += reset.c
 postcar-y += uart.c
 postcar-y += gspi.c
@@ -83,7 +79,6 @@ postcar-y += gspi.c
 verstage-y += car.c
 verstage-y += i2c.c
 verstage-y += gspi.c
-verstage-y += heci.c
 verstage-y += mmap_boot.c
 verstage-y += uart.c
 verstage-y += pmutil.c

src/soc/intel/apollolake/heci.c

@@ -1,22 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <device/device.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <soc/heci.h>
-#include <soc/pci_devs.h>
-
-uint32_t heci_fw_sts(void)
-{
-	return pci_read_config32(PCH_DEV_CSE, REG_SEC_FW_STS0);
-}
-
-bool heci_cse_normal(void)
-{
-	return ((heci_fw_sts() & MASK_SEC_STATUS) == SEC_STATE_NORMAL);
-}
-
-bool heci_cse_done(void)
-{
-	return (!!(heci_fw_sts() & MASK_SEC_FIRMWARE_COMPLETE));
-}

src/soc/intel/apollolake/include/soc/heci.h

@@ -5,29 +5,6 @@
 
 #include <stdint.h>
 
-enum sec_status {
-	SEC_STATE_RESET = 0,
-	SEC_STATE_INIT,
-	SEC_STATE_RECOVERY,
-	SEC_STATE_UNKNOWN0,
-	SEC_STATE_UNKNOWN1,
-	SEC_STATE_NORMAL,
-	SEC_STATE_DISABLE_WAIT,
-	SEC_STATE_TRANSITION,
-	SEC_STATE_INVALID_CPU
-};
-
-#define REG_SEC_FW_STS0					0x40
-#define MASK_SEC_FIRMWARE_COMPLETE			(1 << 9)
-#define MASK_SEC_STATUS					0xf
-
-/* Read Firmware Status register */
-uint32_t heci_fw_sts(void);
-/* Returns true if CSE is in normal status */
-bool heci_cse_normal(void);
-/* Returns true if CSE is done with whatever it was doing */
-bool heci_cse_done(void);
-
 /* Dump CSE state and lockdown HECI1 interface using P2SB message. */
 void heci_cse_lockdown(void);
 

src/soc/intel/apollolake/reset.c

@@ -1,52 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <delay.h>
 #include <fsp/util.h>
-#include <intelblocks/pmclib.h>
-#include <soc/heci.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pm.h>
-#include <timer.h>
-
-#define CSE_WAIT_MAX_MS							1000
-
-void do_global_reset(void)
-{
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
-
-void cf9_reset_prepare(void)
-{
-	struct stopwatch sw;
-
-	/*
-	 * If CSE state is something else than 'normal', it is probably in some
-	 * recovery state. In this case there is no point in  waiting for it to
-	 * get ready so we cross fingers and reset.
-	 */
-	if (!heci_cse_normal()) {
-		printk(BIOS_DEBUG, "CSE is not in normal state, resetting\n");
-		return;
-	}
-
-	/* Reset if CSE is ready */
-	if (heci_cse_done())
-		return;
-
-	printk(BIOS_SPEW, "CSE is not yet ready, waiting\n");
-	stopwatch_init_msecs_expire(&sw, CSE_WAIT_MAX_MS);
-	while (!heci_cse_done()) {
-		if (stopwatch_expired(&sw)) {
-			printk(BIOS_SPEW, "CSE timed out. Resetting\n");
-			return;
-		}
-		mdelay(1);
-	}
-	printk(BIOS_SPEW, "CSE took %lu ms\n", stopwatch_duration_msecs(&sw));
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/cannonlake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <fsp/util.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/common/block/cse/cse_lite.c

@@ -384,7 +384,7 @@ static bool cse_set_and_boot_from_next_bp(enum boot_partition_id bp)
 	cse_board_reset();
 
 	/* If board does not perform the reset, then perform global_reset */
-	do_global_reset();
+	global_reset();
 
 	die("cse_lite: Failed to reset the system\n");
 

src/soc/intel/common/reset.c

@@ -4,16 +4,35 @@
 #include <cf9_reset.h>
 #include <console/console.h>
 #include <halt.h>
+#include <intelblocks/cse.h>
+#include <intelblocks/pmclib.h>
 #include <reset.h>
 
 #include "reset.h"
 
+static void force_global_reset(void)
+{
+	/* Ask CSE to do the global reset */
+	if (CONFIG(SOC_INTEL_COMMON_BLOCK_CSE))
+		if (cse_request_global_reset())
+			return;
+
+	/*
+	 * If ME is unable to reset platform then enable the PMC CF9GR register [B0:D31:F2
+	 * register offset 0xAC bit 20] and force a global reset by writing 0x06 or 0x0E.
+	 */
+	if (CONFIG(SOC_INTEL_COMMON_BLOCK_PMC))
+		pmc_global_reset_enable(true);
+	/* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */
+	do_full_reset();
+}
+
 void global_reset(void)
 {
 	printk(BIOS_INFO, "%s() called!\n", __func__);
 	cf9_reset_prepare();
 	dcache_clean_all();
-	do_global_reset();
+	force_global_reset();
 	halt();
 }
 

src/soc/intel/common/reset.h

@@ -3,14 +3,7 @@
 #ifndef _INTEL_COMMON_RESET_H_
 #define _INTEL_COMMON_RESET_H_
 
-/*
+/* Prepare for reset, run force_global_reset(), halt. */
- * Implement SoC specific global reset (i.e. a reset of both host and
- * ME partitions). Usually the ME is asked to perform the reset first.
- * If that doesn't work out, fall back to a manual global reset.
- */
-void do_global_reset(void);
-
-/* Prepare for reset, run do_global_reset(), halt. */
 __noreturn void global_reset(void);
 
 #endif	/* _INTEL_COMMON_RESET_H_ */

src/soc/intel/elkhartlake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
 #include <fsp/util.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/icelake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <fsp/util.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/jasperlake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <fsp/util.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/skylake/include/soc/me.h

@@ -178,6 +178,5 @@ union me_hfsts6 {
 };
 
 void intel_me_status(void);
-int send_global_reset(void);
 
 #endif

src/soc/intel/skylake/me.c

@@ -339,25 +339,6 @@ void intel_me_status(void)
 	}
 }
 
-int send_global_reset(void)
-{
-	int status = -1;
-	union me_hfsts1 hfs1;
-
-	if (!is_cse_enabled())
-		goto ret;
-
-	/* Check ME operating mode */
-	hfs1.data = me_read_config32(PCI_ME_HFSTS1);
-	if (hfs1.fields.operation_mode)
-		goto ret;
-
-	/* ME should be in Normal Mode for this command */
-	status = cse_request_global_reset();
-ret:
-	return status;
-}
-
 /*
  * This can't be put in intel_me_status because by the time control
  * reaches there, ME doesn't respond to GET_FW_VERSION command.

src/soc/intel/skylake/reset.c

@@ -1,35 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
 #include <fsp/util.h>
-#include <intelblocks/pmclib.h>
 #include <soc/intel/common/reset.h>
-#include <soc/me.h>
-#include <soc/pm.h>
-
-static void do_force_global_reset(void)
-{
-	/*
-	 * BIOS should ensure it does a global reset
-	 * to reset both host and Intel ME by setting
-	 * PCH PMC [B0:D31:F2 register offset 0xAC bit 20]
-	 */
-	pmc_global_reset_enable(true);
-
-	/* Now BIOS can write 0x06 or 0x0E to 0xCF9 port
-	 * to global reset platform */
-	do_full_reset();
-}
-
-void do_global_reset(void)
-{
-	if (!send_global_reset()) {
-		/* If ME unable to reset platform then
-		 * force global reset using PMC CF9GR register*/
-		do_force_global_reset();
-	}
-}
 
 void chipset_handle_reset(uint32_t status)
 {

src/soc/intel/tigerlake/reset.c

@@ -1,23 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <cf9_reset.h>
 #include <console/console.h>
-#include <intelblocks/cse.h>
-#include <intelblocks/pmclib.h>
 #include <fsp/util.h>
 #include <soc/intel/common/reset.h>
-#include <soc/pci_devs.h>
-
-void do_global_reset(void)
-{
-	/* Ask CSE to do the global reset */
-	if (cse_request_global_reset())
-		return;
-
-	/* global reset if CSE fail to reset */
-	pmc_global_reset_enable(1);
-	do_full_reset();
-}
 
 void chipset_handle_reset(uint32_t status)
 {