nb/intel/pineview: Remove dead code in switch
This switch was likely copy-pasted from the one right above it. However, the MEM_CLOCK_800MHz case isn't needed, since that is explicitly checked and avoided before the while loop. With that gone, only the 667MHz/default case is left, which we don't need to switch over anymore. Change-Id: Idfb9cc27dd8718f627d15ba92a9c74c51c2c1c2d Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 1347372 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33407 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: David Hendricks <david.hendricks@gmail.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
parent
589eff7e47
commit
78107939de
|
@ -498,28 +498,12 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
|
|||
lowcas = lsbp;
|
||||
while (cas == 0 && highcas >= lowcas) {
|
||||
FOR_EACH_POPULATED_DIMM(s->dimms, i) {
|
||||
switch (freq) {
|
||||
case MEM_CLOCK_800MHz:
|
||||
if ((s->dimms[i].spd_data[9] > 0x25) ||
|
||||
(s->dimms[i].spd_data[10] > 0x40)) {
|
||||
// CAS too fast, lower it
|
||||
highcas--;
|
||||
break;
|
||||
} else {
|
||||
cas = highcas;
|
||||
}
|
||||
break;
|
||||
case MEM_CLOCK_667MHz:
|
||||
default:
|
||||
if ((s->dimms[i].spd_data[9] > 0x30) ||
|
||||
(s->dimms[i].spd_data[10] > 0x45)) {
|
||||
// CAS too fast, lower it
|
||||
highcas--;
|
||||
break;
|
||||
} else {
|
||||
cas = highcas;
|
||||
}
|
||||
break;
|
||||
if ((s->dimms[i].spd_data[9] > 0x30) ||
|
||||
(s->dimms[i].spd_data[10] > 0x45)) {
|
||||
// CAS too fast, lower it
|
||||
highcas--;
|
||||
} else {
|
||||
cas = highcas;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue