GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/pineview: Remove dead code in switch 

This switch was likely copy-pasted from the one right above it. However,
the MEM_CLOCK_800MHz case isn't needed, since that is explicitly checked
and avoided before the while loop. With that gone, only the
667MHz/default case is left, which we don't need to switch over anymore.

Change-Id: Idfb9cc27dd8718f627d15ba92a9c74c51c2c1c2d
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1347372
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33407
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jacob Garber 2019-06-11 12:45:51 -06:00 committed by Patrick Georgi
parent 589eff7e47
commit 78107939de
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/northbridge/intel/pineview/raminit.c
View File

@ -498,28 +498,12 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
lowcas = lsbp; lowcas = lsbp;
while (cas == 0 && highcas >= lowcas) { while (cas == 0 && highcas >= lowcas) {
FOR_EACH_POPULATED_DIMM(s->dimms, i) { FOR_EACH_POPULATED_DIMM(s->dimms, i) {
switch (freq) { if ((s->dimms[i].spd_data[9] > 0x30) ||
case MEM_CLOCK_800MHz: (s->dimms[i].spd_data[10] > 0x45)) {
if ((s->dimms[i].spd_data[9] > 0x25) || // CAS too fast, lower it
(s->dimms[i].spd_data[10] > 0x40)) { highcas--;
// CAS too fast, lower it } else {
highcas--; cas = highcas;
break;
} else {
cas = highcas;
}
break;
case MEM_CLOCK_667MHz:
default:
if ((s->dimms[i].spd_data[9] > 0x30) ||
(s->dimms[i].spd_data[10] > 0x45)) {
// CAS too fast, lower it
highcas--;
break;
} else {
cas = highcas;
}
break;
} }
} }
} }