From 782c910e867d37867be7459f7619155b24be35e7 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 6 May 2018 21:10:19 -0500 Subject: [PATCH] mainboard/amd/*: Remove unused arguments from SIOW ACPI method Since the SIOW method doesn't use any arguments, don't pass it any, and initialize it as not using any. Change-Id: I3fa2ab8afb7d09c176a94bbd1db27587c36030cd Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/26126 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nico Huber --- src/mainboard/amd/dbm690t/dsdt.asl | 4 ++-- src/mainboard/amd/mahogany/dsdt.asl | 4 ++-- src/mainboard/amd/mahogany_fam10/dsdt.asl | 4 ++-- src/mainboard/amd/tilapia_fam10/dsdt.asl | 4 ++-- src/mainboard/asus/m4a78-em/dsdt.asl | 4 ++-- src/mainboard/asus/m4a785-m/dsdt.asl | 4 ++-- src/mainboard/asus/m4a785t-m/dsdt.asl | 4 ++-- src/mainboard/biostar/am1ml/acpi/sio.asl | 9 --------- src/mainboard/gigabyte/ma785gm/dsdt.asl | 4 ++-- src/mainboard/gigabyte/ma785gmt/dsdt.asl | 4 ++-- src/mainboard/gigabyte/ma78gm/dsdt.asl | 4 ++-- src/mainboard/iei/kino-780am2-fam10/dsdt.asl | 4 ++-- src/mainboard/jetway/pa78vm5/dsdt.asl | 4 ++-- src/mainboard/kontron/kt690/dsdt.asl | 4 ++-- src/mainboard/siemens/sitemp_g1p1/acpi/event.asl | 2 +- src/mainboard/siemens/sitemp_g1p1/dsdt.asl | 2 +- src/mainboard/supermicro/h8scm_fam10/dsdt.asl | 4 ++-- src/mainboard/technexion/tim5690/dsdt.asl | 4 ++-- src/mainboard/technexion/tim8690/dsdt.asl | 4 ++-- 19 files changed, 34 insertions(+), 43 deletions(-) diff --git a/src/mainboard/amd/dbm690t/dsdt.asl b/src/mainboard/amd/dbm690t/dsdt.asl index 78ceb01a7a..748c9fb879 100644 --- a/src/mainboard/amd/dbm690t/dsdt.asl +++ b/src/mainboard/amd/dbm690t/dsdt.asl @@ -886,7 +886,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1432,7 +1432,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl index 798f053e1a..dfffa871e5 100644 --- a/src/mainboard/amd/mahogany/dsdt.asl +++ b/src/mainboard/amd/mahogany/dsdt.asl @@ -882,7 +882,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1448,7 +1448,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl index bbc31056fd..6c72744aef 100644 --- a/src/mainboard/amd/mahogany_fam10/dsdt.asl +++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1491,7 +1491,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl index 03118eea17..4afab9c1be 100644 --- a/src/mainboard/amd/tilapia_fam10/dsdt.asl +++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl index 6dbfc5104a..be3e54da04 100644 --- a/src/mainboard/asus/m4a78-em/dsdt.asl +++ b/src/mainboard/asus/m4a78-em/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl index 6dbfc5104a..be3e54da04 100644 --- a/src/mainboard/asus/m4a785-m/dsdt.asl +++ b/src/mainboard/asus/m4a785-m/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl index f2222b3f37..8e4202683e 100644 --- a/src/mainboard/asus/m4a785t-m/dsdt.asl +++ b/src/mainboard/asus/m4a785t-m/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1475,7 +1475,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/biostar/am1ml/acpi/sio.asl b/src/mainboard/biostar/am1ml/acpi/sio.asl index b423af5caf..7778faa4bb 100644 --- a/src/mainboard/biostar/am1ml/acpi/sio.asl +++ b/src/mainboard/biostar/am1ml/acpi/sio.asl @@ -76,12 +76,3 @@ Method (SIOS, 1) XPNP() } } -Method (SIOW, 1) -{ - EPNP() - Store (0x4, LDN) - Store (Zero, APC0) /* disable keyboard PME */ - Store (0x4, LDN) - Store (0xFF, APC1) /* clear keyboard PME status */ - XPNP() -} diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl index 030ddb9f95..700e4ae93d 100644 --- a/src/mainboard/gigabyte/ma785gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index 030ddb9f95..700e4ae93d 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl index 030ddb9f95..700e4ae93d 100644 --- a/src/mainboard/gigabyte/ma78gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl index 9935d945bf..13f4fa04dc 100644 --- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl +++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1491,7 +1491,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl index bbd4381d38..0a721e9852 100644 --- a/src/mainboard/jetway/pa78vm5/dsdt.asl +++ b/src/mainboard/jetway/pa78vm5/dsdt.asl @@ -924,7 +924,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1490,7 +1490,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/kontron/kt690/dsdt.asl b/src/mainboard/kontron/kt690/dsdt.asl index 982f1053c8..889293f84b 100644 --- a/src/mainboard/kontron/kt690/dsdt.asl +++ b/src/mainboard/kontron/kt690/dsdt.asl @@ -887,7 +887,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1433,7 +1433,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl index 89fbafbe2d..fafb0acc2a 100644 --- a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl +++ b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl @@ -140,7 +140,7 @@ Method(\_WAK, 1) { * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ diff --git a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl index 7a5fc85dcd..121aaf9edd 100644 --- a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl +++ b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl @@ -1132,7 +1132,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "SIEMEN", "SITEMP ", 0x20101005) XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl index bfb9a7a360..1599767e00 100644 --- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl +++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl @@ -942,7 +942,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1526,7 +1526,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/technexion/tim5690/dsdt.asl b/src/mainboard/technexion/tim5690/dsdt.asl index 223c7caefb..44da647f8e 100644 --- a/src/mainboard/technexion/tim5690/dsdt.asl +++ b/src/mainboard/technexion/tim5690/dsdt.asl @@ -886,7 +886,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1432,7 +1432,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN) diff --git a/src/mainboard/technexion/tim8690/dsdt.asl b/src/mainboard/technexion/tim8690/dsdt.asl index 67867974d6..ae82a2a300 100644 --- a/src/mainboard/technexion/tim8690/dsdt.asl +++ b/src/mainboard/technexion/tim8690/dsdt.asl @@ -886,7 +886,7 @@ DefinitionBlock ( * Store(Arg0, Index(WKST,1)) * } */ - \_SB.PCI0.SIOW (Arg0) + \_SB.PCI0.SIOW () Return(WKST) } /* End Method(\_WAK) */ @@ -1432,7 +1432,7 @@ DefinitionBlock ( XPNP() } } - Method (SIOW, 1) + Method (SIOW, 0) { EPNP() Store (0x4, LDN)