GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel: Fix microcode alignment 

CPU_MICROCODE_CBFS_LOC used a non-existing dependency variable
CPU_MICROCODE_IN_CBFS. This broke alignment of microcode in CBFS.

Remoce CPU_MICROCODE_CBFS_LOC from global namespace as it is only
used with PLATFORM_FSP.

CPU_MICROCODE_CBFS_LEN was no longer used at all.

Change-Id: I0454397924d2526d97b1f095cc371ba962873c99
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/7957
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Kyösti Mälkki 2014-12-27 11:47:21 +02:00
parent 1bdd3217a2
commit 78c622443e
2 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/cpu/Kconfig
View File

@ -159,16 +159,3 @@ config CPU_MICROCODE_FILE
default "cpu_microcode.bin" default "cpu_microcode.bin"
help help
The path and filename of the file containing the CPU microcode. The path and filename of the file containing the CPU microcode.
config CPU_MICROCODE_CBFS_LOC
hex "Microcode address in CBFS"
depends on CPU_MICROCODE_IN_CBFS
default 0
config CPU_MICROCODE_CBFS_LEN
hex "Microcode length in CBFS"
depends on CPU_MICROCODE_IN_CBFS
default 0xC000
help
The microcode needs a specific length to get correctly
detected and loaded by all CPUs.

2
src/cpu/Makefile.inc
View File

@ -29,7 +29,7 @@ cpu_ucode_cbfs_file = $(obj)/cpu_microcode_blob.bin
cbfs_include_ucode = y cbfs_include_ucode = y
endif endif
ifneq ($(CONFIG_CPU_MICROCODE_CBFS_LOC), 0) ifeq ($(CONFIG_PLATFORM_USES_FSP), y)
cpu_ucode_cbfs_offset = "-b $(CONFIG_CPU_MICROCODE_CBFS_LOC)" cpu_ucode_cbfs_offset = "-b $(CONFIG_CPU_MICROCODE_CBFS_LOC)"
else else
cpu_ucode_cbfs_offset = "-b" cpu_ucode_cbfs_offset = "-b"