From 79a372036bb81cf7259c7d9f8775ef842be225ce Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Thu, 27 Jul 2023 10:16:34 -0600 Subject: [PATCH] mb/system76: Leave TBT LSX0 as FSP configured Do not reconfigured LSX0 so that the FSP values are used. Change-Id: I76e2ab01a5e853e3c1ac78b471ea0aa87d703d52 Signed-off-by: Tim Crawford Reviewed-on: https://review.coreboot.org/c/coreboot/+/76751 Reviewed-by: Jeremy Soller Tested-by: build bot (Jenkins) --- src/mainboard/system76/adl/variants/gaze17-3060-b/gpio.c | 4 ++-- src/mainboard/system76/rpl/variants/oryp11/gpio.c | 4 ++-- src/mainboard/system76/tgl-h/variants/oryp8/gpio.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mainboard/system76/adl/variants/gaze17-3060-b/gpio.c b/src/mainboard/system76/adl/variants/gaze17-3060-b/gpio.c index 07fa383c5d..ad895761b0 100644 --- a/src/mainboard/system76/adl/variants/gaze17-3060-b/gpio.c +++ b/src/mainboard/system76/adl/variants/gaze17-3060-b/gpio.c @@ -137,8 +137,8 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_E15, NONE), PAD_NC(GPP_E16, NONE), PAD_CFG_GPI(GPP_E17, NONE, DEEP), // BOARD_ID3 - PAD_NC(GPP_E18, NATIVE), // TBT_LSX0_TXD - PAD_NC(GPP_E19, NATIVE), // TBT_LSX0_RXD + // GPP_E18 (TBT_LSX0_TXD) configured by FSP + // GPP_E19 (TBT_LSX0_RXD) configured by FSP PAD_NC(GPP_E20, NONE), PAD_CFG_GPO(GPP_E21, 0, DEEP), // Strap 14 of 24 PAD_NC(GPP_E22, NONE), diff --git a/src/mainboard/system76/rpl/variants/oryp11/gpio.c b/src/mainboard/system76/rpl/variants/oryp11/gpio.c index 74fbde85bc..20ecef6b6c 100644 --- a/src/mainboard/system76/rpl/variants/oryp11/gpio.c +++ b/src/mainboard/system76/rpl/variants/oryp11/gpio.c @@ -137,8 +137,8 @@ static const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E15, 1, DEEP), // CCD_FW_WP# PAD_CFG_GPO(GPP_E16, 1, DEEP), PAD_CFG_GPI(GPP_E17, NONE, DEEP), // BOARD_ID3 - PAD_NC(GPP_E18, NATIVE), // GPP_E18_TBT_LSX0_TXD - PAD_NC(GPP_E19, NATIVE), // GPP_E19_TBT_LSX0_RXD + // GPP_E18 (TBT_LSX0_TXD) configured by FSP + // GPP_E19 (TBT_LSX0_RXD) configured by FSP PAD_CFG_GPO(GPP_E20, 1, DEEP), PAD_CFG_GPO(GPP_E21, 0, DEEP), // GPP_E21 PAD_CFG_GPO(GPP_E22, 1, DEEP), diff --git a/src/mainboard/system76/tgl-h/variants/oryp8/gpio.c b/src/mainboard/system76/tgl-h/variants/oryp8/gpio.c index 4bc22eaf99..fec0fa8b26 100644 --- a/src/mainboard/system76/tgl-h/variants/oryp8/gpio.c +++ b/src/mainboard/system76/tgl-h/variants/oryp8/gpio.c @@ -168,8 +168,8 @@ static const struct pad_config gpio_table[] = { PAD_CFG_GPI(GPP_G9, NONE, DEEP), // GPP_G9 PAD_NC(GPP_G10, NONE), PAD_CFG_GPI(GPP_G11, NONE, DEEP), // GPP_G11 - PAD_NC(GPP_G12, NATIVE), // GPP_G12_TBT_LSX_TXD - PAD_NC(GPP_G13, NATIVE), // GPP_G13_TBT_LSX0_RXD + // GPP_G12 (TBT_LSX0_TXD) configured by FSP + // GPP_G13 (TBT_LSX0_RXD) configured by FSP PAD_NC(GPP_G14, NONE), PAD_CFG_GPI(GPP_G15, NONE, DEEP), // GPP_G15