From 7a0044bf985941671725f8be94f0f1e04749a11f Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Mon, 13 Feb 2017 20:45:54 +0100 Subject: [PATCH] Revert: soc/intel/skylake: Set FSP-S UPD PchHdaIDispCodecDisconnect to 1 This reverts commit 32997fb0bcb9f4183789331a91fd83138776b96f. This change is breaking I2S audio on Kabylake platforms so revert the change to fix audio. BUG=chrome-os-partner:61548,chrome-os-partner:61009 TEST=manual testing on Eve P1 system Change-Id: I3212c8be83078ed57e38501386605e67b87d5bd0 Signed-off-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/18360 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/soc/intel/skylake/chip_fsp20.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c index ebd31349d8..2aef65af29 100644 --- a/src/soc/intel/skylake/chip_fsp20.c +++ b/src/soc/intel/skylake/chip_fsp20.c @@ -190,7 +190,6 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd) params->PchIshEnable = config->IshEnable; params->PchHdaEnable = config->EnableAzalia; params->PchHdaIoBufferOwnership = config->IoBufferOwnership; - params->PchHdaIDispCodecDisconnect = 1; params->PchHdaDspEnable = config->DspEnable; params->XdciEnable = config->XdciEnable; params->Device4Enable = config->Device4Enable;