From 7a0b9b680b9459ac64e90c942f76fe765063e585 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Mon, 29 Mar 2021 12:46:59 +0200 Subject: [PATCH] mb/prodrive/hermes: Drop Vref configuration for older boards Drop Vref verbs from the baseboard table as it's not required for Rev. 3 and earlier. Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/51919 Tested-by: build bot (Jenkins) Reviewed-by: Christian Walter --- .../prodrive/hermes/variants/baseboard/hda_verb.c | 14 +------------- .../prodrive/hermes/variants/r04/hda_verb.c | 2 +- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c index dc9779496c..0e5d3590b3 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c +++ b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c @@ -6,21 +6,9 @@ const u32 cim_verb_data[] = { 0x10ec0888, /* Codec Vendor / Device ID: Realtek ALC888 */ 0x10ec0888, /* Subsystem ID */ - 17, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0, 0x10ec0888), - /* Port configuration control */ - - 0x018707e1, /* port B VREF 50% of LDO-OUT */ - 0x019707e1, /* port F VREF 50% of LDO-OUT */ - 0x01b707e1, /* port E VREF 50% of LDO-OUT*/ - 0x0205000d, /* pin 37 vrefo hidden register - used as port C vref */ - - 0x02041000, /* pin 37 vrefo 50% of LDO-OUT */ - 0x02041000, /* Dummy entry */ - 0x02041000, /* Dummy entry */ - 0x02041000, /* Dummy entry */ - /* Pin widgets */ AZALIA_PIN_CFG(0, 0x11, 0x411111f0), /* SPDIF-OUT2 - disabled */ AZALIA_PIN_CFG(0, 0x12, 0x411111f0), /* digital MIC - disabled */ diff --git a/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c b/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c index ddb8661187..f9a3cb33c7 100644 --- a/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c +++ b/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c @@ -66,7 +66,7 @@ void mainboard_r0x_configure_alc888(u8 *base, u32 viddid) const u32 verbs[] = { AZALIA_PIN_CFG(0, 0x1b, config), - 0x0205000d, + 0x0205000d, /* Pin 37 vrefo hidden register - used as port C vref */ get_port_c_vref_cfg(board_cfg->blue_rear_vref), }; azalia_program_verb_table(base, verbs, ARRAY_SIZE(verbs));