From 7a2cf650326f115215cfbd921514453beeb26c6a Mon Sep 17 00:00:00 2001 From: Seunghwan Kim Date: Fri, 23 Mar 2018 17:18:47 +0900 Subject: [PATCH] mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF method This change remove work-around code for the power issue of MIPI and USB cameras on previous board revision. With the work-around code, PMOF ACPI method cannot turn off MIPI camera. So we need to remove it. BUG=b:74214248 BRANCH=poppy TEST=emerge-nautilus coreboot Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd Signed-off-by: Seunghwan Kim Reviewed-on: https://review.coreboot.org/25337 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- .../baseboard/include/baseboard/acpi/camera_pmic.asl | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index b74fba98d9..5eaf5b758a 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -39,14 +39,7 @@ Scope (\_SB.PCI0.I2C2) Method (PMOF, 0, Serialized) { /* Make Sure all PMIC outputs are off. */ If (LEqual (VSIC, Zero)) { - /* - * On Nautilus Pre-EVT/EVT, the USB and MIPI share the - * same power source, before HW fix in DVT, temporarily - * disabled turn off 3V3_VDD - */ -#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS) CTXS(EN_PP3300_DX_CAM) -#endif } }