From 7a32e88f12efcc424a8e33de0f33f82356d73531 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Thu, 22 Nov 2012 17:37:32 +0100 Subject: [PATCH] libpayload: Fix memalign() for fragmented alignment regions Found a bug in the memory allocator ;-) If the total free space in an alignment region is large enough for an allocation but fragmented, such that there is no contiguous, sufficient large, free space in the region, memalign() was looking at the same region again and again in an endless loop. The advancing to the next region was just missing. Change-Id: I3fad833804675ee495577ca2749b007f46b5ff69 Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/1906 Reviewed-by: Patrick Georgi Tested-by: build bot (Jenkins) --- payloads/libpayload/libc/malloc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 3c5a3fd2a2..82bae3c66e 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -387,6 +387,9 @@ look_further: count = 0; } } + /* The free space in this region is fragmented, + so we will move on and try the next one: */ + reg = reg->next; goto look_further; // end condition is once a new region is allocated - it always has enough space }