GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0: Make vbt_get() conditional 

Skip calling vbt_get() if FSP is not supposed to run GOP.

Change-Id: I6b8cd3646ffcd6df39229d4e36b315dfb7a8c859
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36111
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Marshall Dawson 2019-10-17 07:58:27 -06:00 committed by Martin Roth
parent 1dcc170215
commit 7a9e894550
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/drivers/intel/fsp2_0/silicon_init.c
View File

@ -70,15 +70,12 @@ static void do_silicon_init(struct fsp_header *hdr)
/* Handle any errors returned by FspSiliconInit */ /* Handle any errors returned by FspSiliconInit */
fsp_handle_reset(status); fsp_handle_reset(status);
if (status != FSP_SUCCESS) { if (status != FSP_SUCCESS) {
if (vbt_get()) { /* Assume video failure if attempted to initialize graphics */
/* Attempted to initialize graphics. Assume failure if (CONFIG(RUN_FSP_GOP) && vbt_get())
* is related to a video failure.
*/
postcode = POST_VIDEO_FAILURE; postcode = POST_VIDEO_FAILURE;
} else { else
/* Other silicon initialization failed */ postcode = POST_HW_INIT_FAILURE; /* else generic */
postcode = POST_HW_INIT_FAILURE;
}
printk(BIOS_SPEW, "FspSiliconInit returned 0x%08x\n", status); printk(BIOS_SPEW, "FspSiliconInit returned 0x%08x\n", status);
die_with_post_code(postcode, die_with_post_code(postcode,
"FspSiliconInit returned an error!\n"); "FspSiliconInit returned an error!\n");