GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

sc7180: Correct mmu configuration for AOP SRAM regions

Browse source 
NOC errors detected at runtime in AOP SRAM region
strongly suggested speculative memory accesses were occurring
in memory regions that either don't exist or are device memory
rather than SRAM.

Signed-off-by: T Michael Turney <mturney@codeaurora.org>
Change-Id: I6611dc614c80063c7df057b59337417c8f56fd9c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47261
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
T Michael Turney 2020-11-05 13:49:59 -08:00 committed by Julius Werner
parent ac2da047ac
commit 7bfef7d50c
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/soc/qualcomm/sc7180/include/soc/symbols.h
View file

@ -14,7 +14,8 @@ DECLARE_REGION(dram_modem_extra)
DECLARE_REGION(dcb)
DECLARE_REGION(pmic)
DECLARE_REGION(limits_cfg)
DECLARE_REGION(aop)
DECLARE_REGION(aop_code_ram)
DECLARE_REGION(aop_data_ram)
DECLARE_REGION(modem_id)
#endif /* _SOC_QUALCOMM_SC7180_SYMBOLS_H_ */

3
src/soc/qualcomm/sc7180/memlayout.ld
View file

@ -18,7 +18,8 @@
SECTIONS
{
AOPSRAM_START(0x0B000000)
REGION(aop, 0x0B000000, 0x100000, 4096)
REGION(aop_code_ram, 0x0B000000, 0x80000, 4096)
REGION(aop_data_ram, 0x0B0E0000, 0x20000, 4096)
AOPSRAM_END(0x0B100000)
SSRAM_START(0x14680000)

3
src/soc/qualcomm/sc7180/mmu.c
View file

@ -22,5 +22,6 @@ void sc7180_mmu_init(void)
void soc_mmu_dram_config_post_dram_init(void)
{
mmu_config_range((void *)_aop, REGION_SIZE(aop), CACHED_RAM);
mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM);
mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM);
}