soc/intel/common/cse: Add `cse_send_end_of_post()` as a public function

This patch creates a global function `cse_send_end_of_post()` so
that IA common code may get access to this function for sending EOP
command to the HECI1/CSE device.

Additionally, use static variable to track and prevent sending EOP
command more than once in boot flow.

BUG=b:211954778
TEST=Able to build and boot Brya.

Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I837c5723eca766d21b191b98e39eb52889498bfc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61519
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
This commit is contained in:
Subrata Banik 2022-02-01 00:11:29 +05:30 committed by Felix Held
parent b3671ec5de
commit 7c31d17317
2 changed files with 23 additions and 1 deletions

View File

@ -185,8 +185,15 @@ static void handle_cse_eop_result(enum cse_eop_result result)
}
}
static void set_cse_end_of_post(void *unused)
static void do_send_end_of_post(void)
{
static bool eop_sent = false;
if (eop_sent) {
printk(BIOS_ERR, "EOP already sent\n");
return;
}
/*
* If CSE is already hidden then accessing CSE registers would be wrong and will
* receive junk, hence, return as CSE is already disabled.
@ -203,6 +210,18 @@ static void set_cse_end_of_post(void *unused)
timestamp_add_now(TS_ME_AFTER_END_OF_POST);
set_cse_device_state(PCH_DEVFN_CSE, DEV_IDLE);
eop_sent = true;
}
void cse_send_end_of_post(void)
{
return do_send_end_of_post();
}
static void set_cse_end_of_post(void *unused)
{
return do_send_end_of_post();
}
/*

View File

@ -498,6 +498,9 @@ void heci_set_to_d0i3(void);
/* Function performs the global reset lock */
void cse_control_global_reset_lock(void);
/* Send End of Post (EOP) command to CSE device */
void cse_send_end_of_post(void);
/*
* SoC override API to make heci1 disable using PCR.
*