From 7c6d673c2692e52ba9714f5d3fecd0476e94bd48 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Wed, 13 Oct 2021 14:36:13 -0600 Subject: [PATCH] mb/google/guybrush: Re-arrange override speed config Currently override speed config is applied only for non EM100 cases. For EM100 case, override speed board version defaults to 0 leading to "comparison of unsigned expression >= 0 is always true" error. Fix this error by defining the override speed config for both EM100 and non-EM100 use-cases. BUG=None TEST=Build Guybrush for both EM100 and non-EM100 cases. Signed-off-by: Karthikeyan Ramasubramanian Change-Id: Id8ee7b01c69c4555d6e6a7b0d5f095ea3aaf3405 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58309 Reviewed-by: Felix Held Reviewed-by: Raul Rangel Reviewed-by: Rob Barnes Tested-by: build bot (Jenkins) --- src/mainboard/google/guybrush/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index e5f138258f..489c045524 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -111,6 +111,8 @@ config NORMAL_READ_SPI_SPEED config ALT_SPI_SPEED default 0 # 66MHz +endif # !EM100 + config OVERRIDE_EFS_SPI_SPEED int default 3 if EM100 @@ -127,8 +129,6 @@ config OVERRIDE_EFS_SPI_SPEED_MIN_BOARD Minimum board version starting which the Override EFS SPI Speed configuration has to be applied. -endif # !EM100 - config VARIANT_DIR default "guybrush" if BOARD_GOOGLE_GUYBRUSH default "nipperkin" if BOARD_GOOGLE_NIPPERKIN