GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/gitconfig: Replace subshells with braces 

The check for `user.name` and `user.email` being set is done in
`gitconfig.sh` and it uses two subshells where none is actually needed.
Stream redirection can be consolidated.

Change-Id: Ia1d19eb3c11f9d11f030dcc179bc175956cd7116
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Reviewed-on: https://review.coreboot.org/23250
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alex Thiessen 2018-01-13 19:27:45 +00:00 committed by Patrick Georgi
parent 7459eeb18a
commit 7c7181fc96
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
util/gitconfig/gitconfig.sh
View File

@ -59,9 +59,9 @@ git submodule update --init --checkout"
git config alias.sup-destroy "!git submodule deinit --all --force; \
git submodule update --init --checkout"
(git config --includes user.name >/dev/null && \
git config --includes user.email >/dev/null) || \
(printf "Please configure your name and email in git:\n\n\
{ git config --includes user.name && \
git config --includes user.email; } >/dev/null || \
{ printf "Please configure your name and email in git:\n\n\
git config --global user.name \"Your Name Comes Here\"\n\
git config --global user.email your.email@example.com\n"; \
exit 1)
exit 1; }