GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/board_status.sh: Fix command for fetching the kernel log 

94b761c8e (util/board_status: run dmesg with sudo) attempted to
fetch the console as root locally but instead sudo was put in front
of the remote path which runs as root anyways.

Also unless quotation marks are used the cmd function will see 'sudo'
and 'dmesg' as separate aruguments.

Change-Id: Ib9e9e4b443f4e3ad04c5fda2c2ce626255a190f2
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/30264
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Arthur Heymans 2018-12-16 22:38:58 +01:00 committed by Patrick Georgi
parent 3080fe0a0c
commit 7ccb2821d2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/board_status/board_status.sh
View File

@ -381,7 +381,7 @@ elif [ -n "$REMOTE_HOST" ]; then
cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
echo "Getting remote dmesg" echo "Getting remote dmesg"
cmd $REMOTE sudo dmesg "${tmpdir}/${results}/kernel_log.txt" cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
else else
echo "Verifying that CBMEM is available" echo "Verifying that CBMEM is available"
if [ $(id -u) -ne 0 ]; then if [ $(id -u) -ne 0 ]; then
@ -403,7 +403,7 @@ else
cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
echo "Getting local dmesg" echo "Getting local dmesg"
cmd $LOCAL dmesg "${tmpdir}/${results}/kernel_log.txt" cmd $LOCAL "sudo dmesg" "${tmpdir}/${results}/kernel_log.txt"
fi fi
# #