From 7cf0ff45c69eb3dbb49d27535c8a33a264a0d3aa Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 17 May 2021 10:14:52 +0200 Subject: [PATCH] mainboard: Drop useless `acpi_tables.c` files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `tcrt` and `tpsv` values in GNVS can be used to implement thermal management in ACPI. However, not all mainboards use these values. On mainboards where `tcrt` and `tpsv` are not used in ACPI tables and are the only values set in the `mainboard_fill_gnvs` function, remove them as well as the entire `acpi_tables.c` file. Most files come from autoport, which unconditionally generates this file. Change-Id: If2315ddd9700e2da0a24ffecc20acb5c1a1d688e Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/54353 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Michael Niewöhner --- src/mainboard/asrock/b75pro3-m/acpi_tables.c | 10 ---------- src/mainboard/asrock/b85m_pro4/acpi_tables.c | 10 ---------- src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c | 10 ---------- src/mainboard/asus/p8h61-m_pro/acpi_tables.c | 10 ---------- src/mainboard/asus/p8z77-m_pro/acpi_tables.c | 13 ------------- src/mainboard/asus/p8z77-v_lx2/acpi_tables.c | 10 ---------- src/mainboard/compulab/intense_pc/acpi_tables.c | 11 ----------- src/mainboard/dell/optiplex_9010/acpi_tables.c | 10 ---------- .../hp/compaq_8200_elite_sff/acpi_tables.c | 10 ---------- src/mainboard/hp/z220_sff_workstation/acpi_tables.c | 10 ---------- src/mainboard/msi/ms7707/acpi_tables.c | 10 ---------- .../sapphire/pureplatinumh61/acpi_tables.c | 10 ---------- src/mainboard/supermicro/x9scl/acpi_tables.c | 10 ---------- 13 files changed, 134 deletions(-) delete mode 100644 src/mainboard/asrock/b75pro3-m/acpi_tables.c delete mode 100644 src/mainboard/asrock/b85m_pro4/acpi_tables.c delete mode 100644 src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c delete mode 100644 src/mainboard/asus/p8h61-m_pro/acpi_tables.c delete mode 100644 src/mainboard/asus/p8z77-m_pro/acpi_tables.c delete mode 100644 src/mainboard/asus/p8z77-v_lx2/acpi_tables.c delete mode 100644 src/mainboard/compulab/intense_pc/acpi_tables.c delete mode 100644 src/mainboard/dell/optiplex_9010/acpi_tables.c delete mode 100644 src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c delete mode 100644 src/mainboard/hp/z220_sff_workstation/acpi_tables.c delete mode 100644 src/mainboard/msi/ms7707/acpi_tables.c delete mode 100644 src/mainboard/sapphire/pureplatinumh61/acpi_tables.c delete mode 100644 src/mainboard/supermicro/x9scl/acpi_tables.c diff --git a/src/mainboard/asrock/b75pro3-m/acpi_tables.c b/src/mainboard/asrock/b75pro3-m/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/asrock/b75pro3-m/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asrock/b85m_pro4/acpi_tables.c b/src/mainboard/asrock/b85m_pro4/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/asrock/b85m_pro4/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c b/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c b/src/mainboard/asus/p8h61-m_pro/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c deleted file mode 100644 index a4204f1c54..0000000000 --- a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - /* critical temp that will shutdown the pc == 95C degrees */ - gnvs->tcrt = 95; - - /* temp to start throttling the cpu == 85C */ - gnvs->tpsv = 85; -} diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c b/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/compulab/intense_pc/acpi_tables.c b/src/mainboard/compulab/intense_pc/acpi_tables.c deleted file mode 100644 index e8e2657999..0000000000 --- a/src/mainboard/compulab/intense_pc/acpi_tables.c +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -/* FIXME: check this function. */ -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/dell/optiplex_9010/acpi_tables.c b/src/mainboard/dell/optiplex_9010/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/dell/optiplex_9010/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c b/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c b/src/mainboard/hp/z220_sff_workstation/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/msi/ms7707/acpi_tables.c b/src/mainboard/msi/ms7707/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/msi/ms7707/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c deleted file mode 100644 index 92b9d1c25d..0000000000 --- a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/supermicro/x9scl/acpi_tables.c b/src/mainboard/supermicro/x9scl/acpi_tables.c deleted file mode 100644 index 230584ee4a..0000000000 --- a/src/mainboard/supermicro/x9scl/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -}