GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lenovo/t530: Be safe by disabling blink gpio hw with a writeout 

This disables the blink hardware as it seems to be in the dump. This is
safer as it does not rely on 0 as the reset value when '0x00040000' is
the default according to the util/inteltool. As seen:

gpiobase+0x0018: 0x00040000 (GPO_BLINK) DIFF

Change-Id: Ia1fde108bf3752484f5e991600c435f776af0ced
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6436
Tested-by: build bot (Jenkins)
Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-08-01 20:30:21 +10:00
parent 9ba922f8bd
commit 7cf3d226e2
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/lenovo/t530/romstage.c
View File

@ -186,6 +186,7 @@ void main(unsigned long bist)
outl(0x3962a5ff, DEFAULT_GPIOBASE + GPIO_USE_SEL); outl(0x3962a5ff, DEFAULT_GPIOBASE + GPIO_USE_SEL);
outl(0x8ebf6aff, DEFAULT_GPIOBASE + GP_IO_SEL); outl(0x8ebf6aff, DEFAULT_GPIOBASE + GP_IO_SEL);
outl(0x66917ebb, DEFAULT_GPIOBASE + GP_LVL); outl(0x66917ebb, DEFAULT_GPIOBASE + GP_LVL);
outl(0x00000000, DEFAULT_GPIOBASE + GPO_BLINK);
outl(0x00002002, DEFAULT_GPIOBASE + GPI_INV); outl(0x00002002, DEFAULT_GPIOBASE + GPI_INV);
outl(0x02ff08fe, DEFAULT_GPIOBASE + GPIO_USE_SEL2); outl(0x02ff08fe, DEFAULT_GPIOBASE + GPIO_USE_SEL2);
outl(0x1f47f7fd, DEFAULT_GPIOBASE + GP_IO_SEL2); outl(0x1f47f7fd, DEFAULT_GPIOBASE + GP_IO_SEL2);