GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: log event when MRC cache is updated 

Log when the MRC cache is attempted to be updated with status
of success or failure. Just one slot is supported currently
which is deemed 'normal'. This is because there are more slots
anticipated in the future.

BUG=chrome-os-partner:59395

Change-Id: I0f81458325697aff9924cc359a4173e0d35da5da
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/17231
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Aaron Durbin 2016-11-04 10:07:14 -05:00 committed by Furquan Shaikh
parent d5be4e3d7e
commit 7d9068fe0b
2 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/include/elog.h
View File

@ -149,6 +149,16 @@ struct elog_event_data_me_extended {
#define ELOG_TYPE_WAKE 0xa8 #define ELOG_TYPE_WAKE 0xa8
#define ELOG_TYPE_FW_WAKE 0xa9 #define ELOG_TYPE_FW_WAKE 0xa9
/* Memory Cache Update */
#define ELOG_TYPE_MEM_CACHE_UPDATE 0xaa
#define ELOG_MEM_CACHE_UPDATE_SLOT_NORMAL 0
#define ELOG_MEM_CACHE_UPDATE_STATUS_SUCCESS 0
#define ELOG_MEM_CACHE_UPDATE_STATUS_FAIL 1
struct elog_event_mem_cache_update {
u8 slot;
u8 status;
} __attribute__ ((packed));
#if CONFIG_ELOG #if CONFIG_ELOG
/* Eventlog backing storage must be initialized before calling elog_init(). */ /* Eventlog backing storage must be initialized before calling elog_init(). */
extern int elog_init(void); extern int elog_init(void);

19
src/soc/intel/common/mrc_cache.c
View File

@ -17,6 +17,7 @@
#include <bootstate.h> #include <bootstate.h>
#include <console/console.h> #include <console/console.h>
#include <cbmem.h> #include <cbmem.h>
#include <elog.h>
#include <fmap.h> #include <fmap.h>
#include <ip_checksum.h> #include <ip_checksum.h>
#include <vboot/vboot_common.h> #include <vboot/vboot_common.h>
@ -281,6 +282,18 @@ static int protect_mrc_cache(const struct mrc_data_region *region)
return 0; return 0;
} }
static void log_event_cache_update(uint8_t slot, uint8_t status)
{
const int type = ELOG_TYPE_MEM_CACHE_UPDATE;
struct elog_event_mem_cache_update event = {
.slot = slot,
.status = status,
};
if (elog_add_event_raw(type, &event, sizeof(event)) < 0)
printk(BIOS_ERR, "Failed to log mem cache update event.\n");
}
static void update_mrc_cache(void *unused) static void update_mrc_cache(void *unused)
{ {
const struct mrc_saved_data *current_boot; const struct mrc_saved_data *current_boot;
@ -336,7 +349,13 @@ static void update_mrc_cache(void *unused)
current_boot->size + sizeof(*current_boot))) { current_boot->size + sizeof(*current_boot))) {
printk(BIOS_DEBUG, "Failure writing MRC cache to %p.\n", printk(BIOS_DEBUG, "Failure writing MRC cache to %p.\n",
next_slot); next_slot);
log_event_cache_update(ELOG_MEM_CACHE_UPDATE_SLOT_NORMAL,
ELOG_MEM_CACHE_UPDATE_STATUS_FAIL);
} else {
log_event_cache_update(ELOG_MEM_CACHE_UPDATE_SLOT_NORMAL,
ELOG_MEM_CACHE_UPDATE_STATUS_SUCCESS);
} }
protect_mrc_cache(&region); protect_mrc_cache(&region);
} }