GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/vell: Fix camera LED flicker problem 

Camera LED flicker 3 times or so as sensor is being probed
during kernel boot.

Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips
initial probe during kernel boot preventing camera LED flicker.

Corrects that by explicitly sequencing the reset GPIO and power GPIO

BUG=b:219644184
TEST=Build and boot on vell, observe whether camera LED flickers

Change-Id: I846ec4cb5c4527f5664699b31d0d561d390d938c
Signed-off-by: Shon Wang <shon.wang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63441
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Shon Wang 2022-04-07 16:23:14 +08:00 committed by Felix Held
parent be918747a3
commit 7e22ac15b2
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/mainboard/google/brya/variants/vell/overridetree.cb
View File

@ -299,11 +299,12 @@ chip soc/intel/alderlake
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "ssdb.lanes_used" = "4" register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "0" register "ssdb.link_used" = "1"
register "num_freq_entries" = "2" register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000" register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000" register "link_freq[1]" = "180000000"
register "remote_name" = ""IPU0"" register "remote_name" = ""IPU0""
register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"
#Controls #Controls
register "clk_panel.clks[0].clknum" = "IMGCLKOUT_2" register "clk_panel.clks[0].clknum" = "IMGCLKOUT_2"
@ -313,28 +314,27 @@ chip soc/intel/alderlake
register "gpio_panel.gpio[1].gpio_num" = "GPP_C4" #power register "gpio_panel.gpio[1].gpio_num" = "GPP_C4" #power
#_ON #_ON
register "on_seq.ops_cnt" = "5" register "on_seq.ops_cnt" = "4"
register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)"
register "on_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(1, 5)" register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" register "on_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 5)"
register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 5)" register "on_seq.ops[3]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
#_OFF #_OFF
register "off_seq.ops_cnt" = "3" register "off_seq.ops_cnt" = "3"
register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(1, 0)"
register "off_seq.ops[1]" = "SEQ_OPS_CLK_DISABLE(0, 0)" register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"
register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" register "off_seq.ops[2]" = "SEQ_OPS_CLK_DISABLE(0, 0)"
device i2c 36 on end device i2c 36 on end
end end
chip drivers/intel/mipi_camera chip drivers/intel/mipi_camera
register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"
register "acpi_uid" = "1" register "acpi_uid" = "1"
register "acpi_name" = ""NVM0"" register "acpi_name" = ""NVM0""
register "chip_name" = ""GT24C08"" register "chip_name" = ""GT24C08""
register "device_type" = "INTEL_ACPI_CAMERA_NVM" register "device_type" = "INTEL_ACPI_CAMERA_NVM"
register "pr0" = ""\\_SB.PCI0.I2C2.CAM0.PRIC""
register "nvm_compat" = ""atmel,24c1024"" register "nvm_compat" = ""atmel,24c1024""
register "nvm_size" = "0x2000" register "nvm_size" = "0x2000"