AGESA f14/f15tn/f16kb: Factor out memory settings

We use the same values everywhere, so we might as well factor them out.

TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.

Change-Id: Ie6f166034d5d642dff37730a8d83264fb2e019b4
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41663
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Krystian Hebel <krystian.hebel@3mdeb.com>

src/mainboard/amd/inagua/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL				0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT			1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE		(0)
-#define DFLT_SCRUB_L2_RATE		(0)
-#define DFLT_SCRUB_L3_RATE		(0)
-#define DFLT_SCRUB_IC_RATE		(0)
-#define DFLT_SCRUB_DC_RATE		(0)
-#define DFLT_MEMORY_QUADRANK_TYPE	QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE		(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/amd/olivehill/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   olivehill_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&olivehill_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/amd/parmer/buildOpts.c

@@ -302,15 +302,4 @@ GPIO_CONTROL   parmer_gpio[] = {
 };
 #define BLDCFG_FCH_GPIO_CONTROL_LIST           (&parmer_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/amd/persimmon/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/amd/south_station/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL           0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT       1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/amd/thatcher/buildOpts.c

@@ -302,15 +302,4 @@ GPIO_CONTROL   thatcher_gpio[] = {
 };
 #define BLDCFG_FCH_GPIO_CONTROL_LIST           (&thatcher_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/amd/union_station/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL           0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT       1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/asrock/e350m1/buildOpts.c

@@ -197,16 +197,5 @@
 #define POWER_DOWN_BY_CHANNEL				0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT			1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/asrock/imb-a180/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   imba180_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&imba180_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/asus/am1i-a/buildOpts.c

@@ -313,16 +313,5 @@ GPIO_CONTROL   imba180_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&imba180_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 /* AGESA nonsense: this header depends on the definitions above */
 #include <PlatformInstall.h>

src/mainboard/asus/f2a85-m/buildOpts.c

@@ -303,16 +303,5 @@ GPIO_CONTROL   f2a85_m_gpio[] = {
 };
 #define BLDCFG_FCH_GPIO_CONTROL_LIST           (&f2a85_m_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 /* Moving this include up will break AGESA. */
 #include <PlatformInstall.h>

src/mainboard/bap/ode_e20XX/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   gizmo2_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&gizmo2_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/biostar/a68n_5200/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   olivehill_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&olivehill_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/biostar/am1ml/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   imba180_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&imba180_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/elmex/pcm205400/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/gizmosphere/gizmo/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/gizmosphere/gizmo2/buildOpts.c

@@ -300,15 +300,4 @@ GPIO_CONTROL   gizmo2_gpio[] = {
 };
 //#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&gizmo2_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/hp/abm/buildOpts.c

@@ -314,15 +314,4 @@ GPIO_CONTROL   hp_abm_gpio[] = {
 };
 #define BLDCFG_FCH_GPIO_CONTROL_LIST           (&hp_abm_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 #include <PlatformInstall.h>

src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c

@@ -346,16 +346,5 @@ SCI_MAP_CONTROL m6_1035dx_sci_map[] = {
 };
 #define BLDCFG_FCH_SCI_MAP_LIST			(&m6_1035dx_sci_map[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 /* AGESA nonsense: this header depends on the definitions above */
 #include <PlatformInstall.h>

src/mainboard/jetway/nf81-t56n-lf/buildOpts.c

@@ -190,19 +190,6 @@
 #define POWER_DOWN_BY_CHANNEL			0 /**< Channel power down mode */
 #define POWER_DOWN_BY_CHIP_SELECT		1 /**< Chip select power down mode */
 
-/**
- * The following definitions specify the default values for various parameters
- * in which there are no clearly defined defaults to be used in the common
- * file. The values below are based on product and BKDG content.
- */
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 /* AGESA nonsense: this header depends on the definitions above */
 /* Instantiate all solution relevant data. */
 #include <PlatformInstall.h>

src/mainboard/lenovo/g505s/buildOpts.c

@@ -346,16 +346,5 @@ SCI_MAP_CONTROL lenovo_g505s_sci_map[] = {
 };
 #define BLDCFG_FCH_SCI_MAP_LIST			(&lenovo_g505s_sci_map[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 /* AGESA nonsense: this header depends on the definitions above */
 #include <PlatformInstall.h>

src/mainboard/lippert/frontrunner-af/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/lippert/toucan-af/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/mainboard/msi/ms7721/buildOpts.c

@@ -303,16 +303,5 @@ GPIO_CONTROL   ms7721_m_gpio[] = {
 };
 #define BLDCFG_FCH_GPIO_CONTROL_LIST           (&ms7721_m_gpio[0])
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.  The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE            (0)
-#define DFLT_SCRUB_L2_RATE              (0)
-#define DFLT_SCRUB_L3_RATE              (0)
-#define DFLT_SCRUB_IC_RATE              (0)
-#define DFLT_SCRUB_DC_RATE              (0)
-#define DFLT_MEMORY_QUADRANK_TYPE       QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE              (5000)
-
 /* Moving this include up will break AGESA. */
 #include <PlatformInstall.h>

src/mainboard/pcengines/apu1/buildOpts.c

@@ -191,16 +191,5 @@
 #define POWER_DOWN_BY_CHANNEL			0 ///< Channel power down mode
 #define POWER_DOWN_BY_CHIP_SELECT		1 ///< Chip select power down mode
 
-// The following definitions specify the default values for various parameters in which there are
-// no clearly defined defaults to be used in the common file.	The values below are based on product
-// and BKDG content, please consult the AGESA Memory team for consultation.
-#define DFLT_SCRUB_DRAM_RATE			(0)
-#define DFLT_SCRUB_L2_RATE				(0)
-#define DFLT_SCRUB_L3_RATE				(0)
-#define DFLT_SCRUB_IC_RATE				(0)
-#define DFLT_SCRUB_DC_RATE				(0)
-#define DFLT_MEMORY_QUADRANK_TYPE		QUADRANK_UNBUFFERED
-#define DFLT_VRM_SLEW_RATE				(5000)
-
 // Instantiate all solution relevant data.
 #include <PlatformInstall.h>

src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h

@@ -583,7 +583,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_SLEW_RATE
   #define CFG_VRM_SLEW_RATE                BLDCFG_VRM_SLEW_RATE
 #else
-  #define CFG_VRM_SLEW_RATE                DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_SLEW_RATE                (5000)
 #endif
 
 #ifdef BLDCFG_VRM_INRUSH_CURRENT_LIMIT
@@ -613,7 +613,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_NB_SLEW_RATE
   #define CFG_VRM_NB_SLEW_RATE             BLDCFG_VRM_NB_SLEW_RATE
 #else
-  #define CFG_VRM_NB_SLEW_RATE             DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_NB_SLEW_RATE             (5000)
 #endif
 
 #ifdef BLDCFG_VRM_NB_INRUSH_CURRENT_LIMIT
@@ -722,7 +722,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_MEMORY_QUADRANK_TYPE
   #define CFG_MEMORY_QUADRANK_TYPE              BLDCFG_MEMORY_QUADRANK_TYPE
 #else
-  #define CFG_MEMORY_QUADRANK_TYPE              DFLT_MEMORY_QUADRANK_TYPE
+  #define CFG_MEMORY_QUADRANK_TYPE              QUADRANK_UNBUFFERED
 #endif
 
 #ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -848,31 +848,31 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_SCRUB_DRAM_RATE
   #define CFG_SCRUB_DRAM_RATE         BLDCFG_SCRUB_DRAM_RATE
 #else
-  #define CFG_SCRUB_DRAM_RATE         DFLT_SCRUB_DRAM_RATE
+  #define CFG_SCRUB_DRAM_RATE         (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L2_RATE
   #define CFG_SCRUB_L2_RATE           BLDCFG_SCRUB_L2_RATE
 #else
-  #define CFG_SCRUB_L2_RATE           DFLT_SCRUB_L2_RATE
+  #define CFG_SCRUB_L2_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L3_RATE
   #define CFG_SCRUB_L3_RATE           BLDCFG_SCRUB_L3_RATE
 #else
-  #define CFG_SCRUB_L3_RATE           DFLT_SCRUB_L3_RATE
+  #define CFG_SCRUB_L3_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_IC_RATE
   #define CFG_SCRUB_IC_RATE           BLDCFG_SCRUB_IC_RATE
 #else
-  #define CFG_SCRUB_IC_RATE           DFLT_SCRUB_IC_RATE
+  #define CFG_SCRUB_IC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_DC_RATE
   #define CFG_SCRUB_DC_RATE           BLDCFG_SCRUB_DC_RATE
 #else
-  #define CFG_SCRUB_DC_RATE           DFLT_SCRUB_DC_RATE
+  #define CFG_SCRUB_DC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_ECC_SYNC_FLOOD

src/vendorcode/amd/agesa/f15tn/Config/PlatformInstall.h

@@ -1758,7 +1758,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_SLEW_RATE
   #define CFG_VRM_SLEW_RATE                BLDCFG_VRM_SLEW_RATE
 #else
-  #define CFG_VRM_SLEW_RATE                DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_SLEW_RATE                (5000)
 #endif
 
 #ifdef BLDCFG_VRM_MAXIMUM_CURRENT_LIMIT
@@ -1820,7 +1820,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_NB_SLEW_RATE
   #define CFG_VRM_NB_SLEW_RATE             BLDCFG_VRM_NB_SLEW_RATE
 #else
-  #define CFG_VRM_NB_SLEW_RATE             DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_NB_SLEW_RATE             (5000)
 #endif
 
 #ifdef BLDCFG_PLAT_NUM_IO_APICS
@@ -1928,7 +1928,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_MEMORY_QUADRANK_TYPE
   #define CFG_MEMORY_QUADRANK_TYPE              BLDCFG_MEMORY_QUADRANK_TYPE
 #else
-  #define CFG_MEMORY_QUADRANK_TYPE              DFLT_MEMORY_QUADRANK_TYPE
+  #define CFG_MEMORY_QUADRANK_TYPE              QUADRANK_UNBUFFERED
 #endif
 
 #ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -2060,31 +2060,31 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_SCRUB_DRAM_RATE
   #define CFG_SCRUB_DRAM_RATE         BLDCFG_SCRUB_DRAM_RATE
 #else
-  #define CFG_SCRUB_DRAM_RATE         DFLT_SCRUB_DRAM_RATE
+  #define CFG_SCRUB_DRAM_RATE         (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L2_RATE
   #define CFG_SCRUB_L2_RATE           BLDCFG_SCRUB_L2_RATE
 #else
-  #define CFG_SCRUB_L2_RATE           DFLT_SCRUB_L2_RATE
+  #define CFG_SCRUB_L2_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L3_RATE
   #define CFG_SCRUB_L3_RATE           BLDCFG_SCRUB_L3_RATE
 #else
-  #define CFG_SCRUB_L3_RATE           DFLT_SCRUB_L3_RATE
+  #define CFG_SCRUB_L3_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_IC_RATE
   #define CFG_SCRUB_IC_RATE           BLDCFG_SCRUB_IC_RATE
 #else
-  #define CFG_SCRUB_IC_RATE           DFLT_SCRUB_IC_RATE
+  #define CFG_SCRUB_IC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_DC_RATE
   #define CFG_SCRUB_DC_RATE           BLDCFG_SCRUB_DC_RATE
 #else
-  #define CFG_SCRUB_DC_RATE           DFLT_SCRUB_DC_RATE
+  #define CFG_SCRUB_DC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_ECC_SYNC_FLOOD

src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h

@@ -747,7 +747,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_SLEW_RATE
   #define CFG_VRM_SLEW_RATE                BLDCFG_VRM_SLEW_RATE
 #else
-  #define CFG_VRM_SLEW_RATE                DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_SLEW_RATE                (5000)
 #endif
 
 #ifdef BLDCFG_VRM_MAXIMUM_CURRENT_LIMIT
@@ -789,7 +789,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_VRM_NB_SLEW_RATE
   #define CFG_VRM_NB_SLEW_RATE             BLDCFG_VRM_NB_SLEW_RATE
 #else
-  #define CFG_VRM_NB_SLEW_RATE             DFLT_VRM_SLEW_RATE
+  #define CFG_VRM_NB_SLEW_RATE             (5000)
 #endif
 
 #ifdef BLDCFG_PLAT_NUM_IO_APICS
@@ -897,7 +897,7 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_MEMORY_QUADRANK_TYPE
   #define CFG_MEMORY_QUADRANK_TYPE              BLDCFG_MEMORY_QUADRANK_TYPE
 #else
-  #define CFG_MEMORY_QUADRANK_TYPE              DFLT_MEMORY_QUADRANK_TYPE
+  #define CFG_MEMORY_QUADRANK_TYPE              QUADRANK_UNBUFFERED
 #endif
 
 #ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -1029,31 +1029,31 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
 #ifdef BLDCFG_SCRUB_DRAM_RATE
   #define CFG_SCRUB_DRAM_RATE         BLDCFG_SCRUB_DRAM_RATE
 #else
-  #define CFG_SCRUB_DRAM_RATE         DFLT_SCRUB_DRAM_RATE
+  #define CFG_SCRUB_DRAM_RATE         (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L2_RATE
   #define CFG_SCRUB_L2_RATE           BLDCFG_SCRUB_L2_RATE
 #else
-  #define CFG_SCRUB_L2_RATE           DFLT_SCRUB_L2_RATE
+  #define CFG_SCRUB_L2_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_L3_RATE
   #define CFG_SCRUB_L3_RATE           BLDCFG_SCRUB_L3_RATE
 #else
-  #define CFG_SCRUB_L3_RATE           DFLT_SCRUB_L3_RATE
+  #define CFG_SCRUB_L3_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_IC_RATE
   #define CFG_SCRUB_IC_RATE           BLDCFG_SCRUB_IC_RATE
 #else
-  #define CFG_SCRUB_IC_RATE           DFLT_SCRUB_IC_RATE
+  #define CFG_SCRUB_IC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_SCRUB_DC_RATE
   #define CFG_SCRUB_DC_RATE           BLDCFG_SCRUB_DC_RATE
 #else
-  #define CFG_SCRUB_DC_RATE           DFLT_SCRUB_DC_RATE
+  #define CFG_SCRUB_DC_RATE           (0)
 #endif
 
 #ifdef BLDCFG_ECC_SYNC_FLOOD