GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim/var/skyrim: Add better descriptors for USB endpoints 

Fix descriptors for USB ports to align with their function and
placement with respect to the schematics.

BUG=N/A
TEST=Builds

Signed-off-by: Jon Murphy <jpmurphy@google.com>
Change-Id: If57bebf9bffd4616c437ec655b64cab3298ac08e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64530
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Jon Murphy 2022-05-19 13:39:03 -06:00 committed by Felix Held
parent d5b1f547c3
commit 7e63dfad5a
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
View File

@ -76,13 +76,13 @@ chip soc/amd/sabrina
chip drivers/usb/acpi chip drivers/usb/acpi
device ref xhci_0_root_hub on device ref xhci_0_root_hub on
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-C Port"" register "desc" = ""USB3 Type-C Port C0 (MLB)""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(1, 1)" register "group" = "ACPI_PLD_GROUP(1, 1)"
device ref usb3_port0 on end device ref usb3_port0 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-C Port"" register "desc" = ""USB2 Type-C Port C0 (MLB)""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(1, 1)" register "group" = "ACPI_PLD_GROUP(1, 1)"
device ref usb2_port0 on end device ref usb2_port0 on end
@ -99,13 +99,13 @@ chip soc/amd/sabrina
chip drivers/usb/acpi chip drivers/usb/acpi
device ref xhci_1_root_hub on device ref xhci_1_root_hub on
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-C Port"" register "desc" = ""USB3 Type-C Port C1 (DB)""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(2, 1)" register "group" = "ACPI_PLD_GROUP(2, 1)"
device ref usb3_port2 on end device ref usb3_port2 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-C Port"" register "desc" = ""USB2 Type-C Port C1 (DB)""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "group" = "ACPI_PLD_GROUP(2, 1)" register "group" = "ACPI_PLD_GROUP(2, 1)"
device ref usb2_port2 on end device ref usb2_port2 on end

4
src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
View File

@ -40,7 +40,7 @@ chip soc/amd/sabrina
register "port_count" = "4" register "port_count" = "4"
device usb 0.0 on # VL822 USB3 hub device usb 0.0 on # VL822 USB3 hub
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-A Port"" register "desc" = ""USB3 Type-A Port A0 (DB)""
register "type" = "UPC_TYPE_USB3_A" register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)" register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 3.0 on end device usb 3.0 on end
@ -68,7 +68,7 @@ chip soc/amd/sabrina
register "port_count" = "4" register "port_count" = "4"
device usb 0.0 on # VL822 USB2 hub device usb 0.0 on # VL822 USB2 hub
chip drivers/usb/acpi chip drivers/usb/acpi
register "desc" = ""Left Type-A Port"" register "desc" = ""USB2 Type-A Port A0 (DB)""
register "type" = "UPC_TYPE_USB3_A" register "type" = "UPC_TYPE_USB3_A"
register "group" = "ACPI_PLD_GROUP(2, 2)" register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 2.0 on end device usb 2.0 on end