From 7e710e047f059025392ed6607909f41114d8e843 Mon Sep 17 00:00:00 2001 From: Marc Jones Date: Thu, 12 Oct 2017 15:19:51 -0600 Subject: [PATCH] amd/soc/common: Print an error if an AGESA callout isn't supported Let the developer or user know that a callout isn't supported. Change-Id: I73a6c6930a6661627ad76e27bbb78be99e237949 Signed-off-by: Marc Jones Reviewed-on: https://review.coreboot.org/21998 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/soc/amd/common/def_callouts.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c index fe0d5497e1..aa35e345b5 100644 --- a/src/soc/amd/common/def_callouts.c +++ b/src/soc/amd/common/def_callouts.c @@ -33,8 +33,12 @@ AGESA_STATUS GetBiosCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr) if (BiosCallouts[i].CalloutName == Func) break; } - if (i >= BiosCalloutsLen) + + if (i >= BiosCalloutsLen) { + printk(BIOS_ERR, "ERROR: AGESA Callout Not Supported: 0x%x", + (u32)Func); return AGESA_UNSUPPORTED; + } return BiosCallouts[i].CalloutPtr(Func, Data, ConfigPtr); }