GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/{common,i82801dx}: Improve TCO debug code 

Report unhandled TCO bits (previously dead code). This
finishes the work done in 3e3b858 (sb/intel/ibexpeak:
Update debug code to match other chips).

Found-by: Coverity Scan, CID 1229598 (DEADCODE)
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: I65df8f3363c62b364e096368a36ba5e9e8894c13
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32179
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jacob Garber 2019-04-03 09:18:32 -06:00 committed by Kyösti Mälkki
parent d2cdfff63b
commit 7eb8eed460
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/intel/common/smihandler.c
View File

@ -418,7 +418,7 @@ static void southbridge_smi_tco(void)
} else if (tco_sts & (1 << 3)) { /* TIMEOUT */ } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
/* Handle TCO timeout */ /* Handle TCO timeout */
printk(BIOS_DEBUG, "TCO Timeout.\n"); printk(BIOS_DEBUG, "TCO Timeout.\n");
} else if (!tco_sts) { } else {
dump_tco_status(tco_sts); dump_tco_status(tco_sts);
} }
} }

2
src/southbridge/intel/i82801dx/smihandler.c
View File

@ -490,7 +490,7 @@ static void southbridge_smi_tco(unsigned int node, smm_state_save_area_t *state_
} else if (tco_sts & (1 << 3)) { /* TIMEOUT */ } else if (tco_sts & (1 << 3)) { /* TIMEOUT */
/* Handle TCO timeout */ /* Handle TCO timeout */
printk(BIOS_DEBUG, "TCO Timeout.\n"); printk(BIOS_DEBUG, "TCO Timeout.\n");
} else if (!tco_sts) { } else {
dump_tco_status(tco_sts); dump_tco_status(tco_sts);
} }
} }