GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default 

The FSP_CAR option has additional configuration options whose default
values result in boot failures. Since default values should always boot,
default to the open-source CAR NEM Enhanced implementation instead. This
also allows us to get rid of an unnecessary vendor-specific special case.

Change-Id: I30b1808f91701c07dce6f1de08c213150e8a675a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34287
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-by: Lean Sheng Tan <lean.sheng.tan@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2019-07-12 15:46:43 +02:00 committed by Patrick Georgi
parent d472c4f01e
commit 7ed704d73d
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/cannonlake/Kconfig
View File

@ -269,8 +269,7 @@ config MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
choice choice
prompt "Cache-as-ram implementation" prompt "Cache-as-ram implementation"
default USE_CANNONLAKE_CAR_NEM_ENHANCED if MAINBOARD_HAS_CHROMEOS default USE_CANNONLAKE_CAR_NEM_ENHANCED
default USE_CANNONLAKE_FSP_CAR
help help
This option allows you to select how cache-as-ram (CAR) is set up. This option allows you to select how cache-as-ram (CAR) is set up.

3
src/soc/intel/icelake/Kconfig
View File

@ -172,8 +172,7 @@ config CBFS_SIZE
choice choice
prompt "Cache-as-ram implementation" prompt "Cache-as-ram implementation"
default USE_ICELAKE_CAR_NEM_ENHANCED if MAINBOARD_HAS_CHROMEOS default USE_ICELAKE_CAR_NEM_ENHANCED
default USE_ICELAKE_FSP_CAR
help help
This option allows you to select how cache-as-ram (CAR) is set up. This option allows you to select how cache-as-ram (CAR) is set up.