GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Configure FSP UPDs to allow coreboot to lockdown 

Configure FSP S UPDs to allow coreboot to handle the lockdown.

The main change here is setting `Write Protection Support` to 0,
as the default is Enabled, which shouldn't allow writes (even though
it seems to).

The UPDs are identical on APL and GLK, but all ones configured
in this patch have been there since their initial releases.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I35185b498315511f3236758caebfe2f9c28fd04a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65039
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2022-06-08 15:00:26 +01:00 committed by Paul Fagerburg
parent d669562663
commit 7ef5376123
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/intel/apollolake/chip.c
View File

@ -16,6 +16,7 @@
#include <intelblocks/p2sb.h> #include <intelblocks/p2sb.h>
#include <intelblocks/power_limit.h> #include <intelblocks/power_limit.h>
#include <intelblocks/xdci.h> #include <intelblocks/xdci.h>
#include <intelpch/lockdown.h>
#include <fsp/api.h> #include <fsp/api.h>
#include <fsp/util.h> #include <fsp/util.h>
#include <intelblocks/cpulib.h> #include <intelblocks/cpulib.h>
@ -697,10 +698,12 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd)
silconfig->SkipMpInit = !CONFIG(USE_INTEL_FSP_MP_INIT); silconfig->SkipMpInit = !CONFIG(USE_INTEL_FSP_MP_INIT);
/* Disable setting of EISS bit in FSP. */ /* coreboot handles the lockdown */
silconfig->LockDownGlobalSmi = 0;
silconfig->BiosLock = 0;
silconfig->BiosInterface = 0;
silconfig->WriteProtectionEnable[0] = 0;
silconfig->SpiEiss = 0; silconfig->SpiEiss = 0;
/* Disable FSP from locking access to the RTC NVRAM */
silconfig->RtcLock = 0; silconfig->RtcLock = 0;
/* Enable Audio clk gate and power gate */ /* Enable Audio clk gate and power gate */