GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfs: remove unused code and prototype 

The code is wrong (it's calling ntohl on an entry point that is actually
already le due to an old cbfs bug) and nothing calls it any more anyway.

Change-Id: Ief2c33faf99e3d2fc410524a5aae7bde378f088b
Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Reviewed-on: http://review.coreboot.org/4090
Tested-by: build bot (Jenkins)
Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Ronald G. Minnich 2013-11-17 11:07:25 -08:00 committed by Ronald G. Minnich
parent 72f15bd2be
commit 7fda0e8e61
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/include/cbfs.h
View File

@ -52,7 +52,6 @@
#include <cbfs_core.h> #include <cbfs_core.h>
int cbfs_execute_stage(struct cbfs_media *media, const char *name);
void *cbfs_load_optionrom(struct cbfs_media *media, uint16_t vendor, void *cbfs_load_optionrom(struct cbfs_media *media, uint16_t vendor,
uint16_t device, void * dest); uint16_t device, void * dest);
void *cbfs_load_payload(struct cbfs_media *media, const char *name); void *cbfs_load_payload(struct cbfs_media *media, const char *name);

19
src/lib/cbfs.c
View File

@ -292,25 +292,6 @@ void * cbfs_load_stage(struct cbfs_media *media, const char *name)
} }
#endif /* CONFIG_RELOCATABLE_RAMSTAGE */ #endif /* CONFIG_RELOCATABLE_RAMSTAGE */
int cbfs_execute_stage(struct cbfs_media *media, const char *name)
{
struct cbfs_stage *stage = (struct cbfs_stage *)
cbfs_get_file_content(media, name, CBFS_TYPE_STAGE);
if (stage == NULL)
return 1;
if (ntohl(stage->compression) != CBFS_COMPRESS_NONE) {
LOG("Unable to run %s: Compressed file"
"Not supported for in-place execution\n", name);
return 1;
}
/* FIXME: This isn't right */
LOG("run @ %p\n", (void *) ntohl((uint32_t) stage->entry));
return run_address((void *)(uintptr_t)ntohll(stage->entry));
}
#if !CONFIG_ALT_CBFS_LOAD_PAYLOAD #if !CONFIG_ALT_CBFS_LOAD_PAYLOAD
void *cbfs_load_payload(struct cbfs_media *media, const char *name) void *cbfs_load_payload(struct cbfs_media *media, const char *name)
{ {