GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB 

Disable SA GV, because factory used Samsung memory with wrong date code.
So we need to use board version to identify build MB phase to disable SA GV.
Disable SA GV when board version equal one.

BUG=b:179747696
BRANCH=firmware-volteer-13672.B
TEST=Built and booted into OS.

Signed-off-by: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Signed-off-by: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51200
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Kevin Chang 2021-03-03 17:44:02 +08:00 committed by Patrick Georgi
parent 30cb21811b
commit 80273918d5
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/volteer/romstage.c
View File

@ -22,4 +22,9 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
bool half_populated = gpio_get(GPIO_MEM_CH_SEL); bool half_populated = gpio_get(GPIO_MEM_CH_SEL);
memcfg_init(mem_cfg, board_cfg, &spd_info, half_populated); memcfg_init(mem_cfg, board_cfg, &spd_info, half_populated);
memcfg_variant_init(mupd);
}
void __weak memcfg_variant_init(FSPM_UPD *mupd)
{
} }

1
src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
View File

@ -21,6 +21,7 @@ const struct cros_gpio *variant_cros_gpios(size_t *num);
const struct mb_cfg *variant_memory_params(void); const struct mb_cfg *variant_memory_params(void);
int variant_memory_sku(void); int variant_memory_sku(void);
void memcfg_variant_init(FSPM_UPD *mupd);
/* Modify devictree settings during ramstage. */ /* Modify devictree settings during ramstage. */
void variant_devtree_update(void); void variant_devtree_update(void);

9
src/mainboard/google/volteer/variants/lindar/memory.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <boardid.h>
static const struct mb_cfg board_memcfg = { static const struct mb_cfg board_memcfg = {
.type = MEM_TYPE_LP4X, .type = MEM_TYPE_LP4X,
@ -59,3 +60,11 @@ const struct mb_cfg *variant_memory_params(void)
{ {
return &board_memcfg; return &board_memcfg;
} }
void memcfg_variant_init(FSPM_UPD *mupd)
{
FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
if (board_id() == 1)
mem_cfg->SaGv = 0x00;
}