GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: Revert Don't expose reset GPIO for touchscreen to OS 

This reverts the code from  commit 728c0787f2 that removes the reset
GPIO from the touchscreen ACPI interface.

That patch exposes a bug which leads to an invalid opcode trap in the
touchscreen code.  Reverting this gets the system working again, but is
not a long-term solution.

BUG=b:162596241
TEST=System boots to login screen.

Change-Id: I57a070d94f961cec43834c8bedd5dafc8a54171a
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43078
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Martin Roth 2020-08-07 18:31:20 +00:00 committed by Aaron Durbin
parent 9c1c00968c
commit 81066b7ce7
4 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/zork/variants/berknip/overridetree.cb
View File

@ -78,7 +78,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic

1
src/mainboard/google/zork/variants/dalboz/overridetree.cb
View File

@ -53,7 +53,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic

1
src/mainboard/google/zork/variants/ezkinil/overridetree.cb
View File

@ -80,7 +80,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/hid chip drivers/i2c/hid

1
src/mainboard/google/zork/variants/trembyle/overridetree.cb
View File

@ -76,7 +76,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time # 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20" register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end device i2c 39 on end
end end
chip drivers/i2c/generic chip drivers/i2c/generic