From 8281a537666081b7785178c4375b5e23e6e2a93a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Sun, 8 Nov 2020 19:32:13 +0100 Subject: [PATCH] mb/supermicro/x11ssm-f: configure "POST complete" gpio for IPMI driver MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Configure the "POST complete" gpio in the devicetree for the BMC/IPMI driver. Also add the pad to early gpio config, since it has an external pull-up, which is wrong and would confuse the BMC. Set the pad's initial value to zero since the "POST complete" signal is active-high and shall be set by the IPMI/BMC driver. Test: Boot the machine via the BMC web interface and check that sensors get read correctly by the IPMI firmware when the payload starts. Tested successfully. Signed-off-by: Michael Niewöhner Change-Id: I6409b2aca90585e44ee5d32df0ae73b259443f32 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48097 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- .../x11-lga1151-series/variants/x11ssm-f/gpio_early.c | 3 +++ .../x11-lga1151-series/variants/x11ssm-f/overridetree.cb | 1 + 2 files changed, 4 insertions(+) diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio_early.c b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio_early.c index 3ea21e0321..ea3ec6d0ae 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio_early.c +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio_early.c @@ -14,6 +14,9 @@ static const struct pad_config early_gpio_table[] = { PAD_CFG_NF(GPP_A8, NONE, DEEP, NF1), PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), + + /* BMC POST_COMPLETE */ + PAD_CFG_GPO(GPP_B20, 0, PLTRST), }; void mainboard_configure_early_gpios(void) diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb index 8bf60d3894..5845607142 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb @@ -91,6 +91,7 @@ chip soc/intel/skylake chip drivers/ipmi use pch_gpio as gpio_dev register "bmc_jumper_gpio" = "GPP_D22" # JPB1 + register "post_complete_gpio" = "GPP_B20" # On cold boot it takes a while for the BMC to start the IPMI service register "wait_for_bmc" = "1" register "bmc_boot_timeout" = "60"