AGESA BiosCallouts: Remove cast
This cast only hides errors in matching the API properly. Change-Id: Ic396dfb572a50ac5ce5c1c83424e1f17f15bad1d Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/12270 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
parent
625b944e75
commit
82860f8549
|
@ -222,7 +222,7 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON
|
|||
pConfig->NumberOfNorthbridges = MAX_NB_COUNT - 1; /* Support limited to primary NB only located at 0:0:0 */
|
||||
//pConfig->StandardHeader.ImageBasePtr = CIMX_B2_IMAGE_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.PcieBasePtr = (VOID *)PCIEX_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.CalloutPtr = (CALLOUT_ENTRY)&rd890_callout_entry;
|
||||
pConfig->StandardHeader.CalloutPtr = &rd890_callout_entry;
|
||||
|
||||
/*
|
||||
* PCI Address to Access NB. Depends on HT topology and configuration for multi NB platform.
|
||||
|
|
|
@ -222,7 +222,7 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON
|
|||
pConfig->NumberOfNorthbridges = MAX_NB_COUNT - 1; /* Support limited to primary NB only located at 0:0:0 */
|
||||
//pConfig->StandardHeader.ImageBasePtr = CIMX_B2_IMAGE_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.PcieBasePtr = (VOID *)PCIEX_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.CalloutPtr = (CALLOUT_ENTRY)&rd890_callout_entry;
|
||||
pConfig->StandardHeader.CalloutPtr = &rd890_callout_entry;
|
||||
|
||||
/*
|
||||
* PCI Address to Access NB. Depends on HT topology and configuration for multi NB platform.
|
||||
|
|
|
@ -222,7 +222,7 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON
|
|||
pConfig->NumberOfNorthbridges = MAX_NB_COUNT - 1; /* Support limited to primary NB only located at 0:0:0 */
|
||||
//pConfig->StandardHeader.ImageBasePtr = CIMX_B2_IMAGE_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.PcieBasePtr = (VOID *)PCIEX_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.CalloutPtr = (CALLOUT_ENTRY)&rd890_callout_entry;
|
||||
pConfig->StandardHeader.CalloutPtr = &rd890_callout_entry;
|
||||
|
||||
/*
|
||||
* PCI Address to Access NB. Depends on HT topology and configuration for multi NB platform.
|
||||
|
|
|
@ -222,7 +222,7 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON
|
|||
pConfig->NumberOfNorthbridges = MAX_NB_COUNT - 1; /* Support limited to primary NB only located at 0:0:0 */
|
||||
//pConfig->StandardHeader.ImageBasePtr = CIMX_B2_IMAGE_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.PcieBasePtr = (VOID *)PCIEX_BASE_ADDRESS;
|
||||
pConfig->StandardHeader.CalloutPtr = (CALLOUT_ENTRY)&rd890_callout_entry;
|
||||
pConfig->StandardHeader.CalloutPtr = &rd890_callout_entry;
|
||||
|
||||
/*
|
||||
* PCI Address to Access NB. Depends on HT topology and configuration for multi NB platform.
|
||||
|
|
|
@ -35,7 +35,7 @@ AGESA_STATUS GetBiosCallout (UINT32 Func, UINTN Data, VOID *ConfigPtr);
|
|||
|
||||
typedef struct {
|
||||
UINT32 CalloutName;
|
||||
AGESA_STATUS (*CalloutPtr) (UINT32 Func, UINTN Data, VOID* ConfigPtr);
|
||||
CALLOUT_ENTRY CalloutPtr;
|
||||
} BIOS_CALLOUT_STRUCT;
|
||||
|
||||
extern const BIOS_CALLOUT_STRUCT BiosCallouts[];
|
||||
|
|
|
@ -41,7 +41,7 @@ AGESA_STATUS agesawrapper_amdinitreset(void)
|
|||
AmdParamStruct.NewStructSize = sizeof(AMD_RESET_PARAMS);
|
||||
AmdParamStruct.NewStructPtr = &AmdResetParams;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
@ -65,7 +65,7 @@ AGESA_STATUS agesawrapper_amdinitearly(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_EARLY;
|
||||
AmdParamStruct.AllocationMethod = PreMemHeap;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
AmdCreateStruct(&AmdParamStruct);
|
||||
|
@ -94,7 +94,7 @@ AGESA_STATUS agesawrapper_amdinitpost(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_POST;
|
||||
AmdParamStruct.AllocationMethod = PreMemHeap;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
@ -127,7 +127,7 @@ AGESA_STATUS agesawrapper_amdinitresume(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_RESUME;
|
||||
AmdParamStruct.AllocationMethod = PreMemHeap;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
AmdCreateStruct(&AmdParamStruct);
|
||||
|
@ -157,7 +157,7 @@ AGESA_STATUS agesawrapper_amdinitenv(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_ENV;
|
||||
AmdParamStruct.AllocationMethod = PostMemDram;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
AmdCreateStruct(&AmdParamStruct);
|
||||
|
@ -183,7 +183,7 @@ AGESA_STATUS agesawrapper_amds3laterestore(void)
|
|||
AmdInterfaceParams.AllocationMethod = ByHost;
|
||||
AmdInterfaceParams.AgesaFunctionName = AMD_S3LATE_RESTORE;
|
||||
AmdInterfaceParams.NewStructPtr = &AmdS3LateParams;
|
||||
AmdInterfaceParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdInterfaceParams.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdS3LateParamsPtr = &AmdS3LateParams;
|
||||
AmdInterfaceParams.NewStructSize = sizeof(AMD_S3LATE_PARAMS);
|
||||
|
||||
|
@ -216,7 +216,7 @@ AGESA_STATUS agesawrapper_amdinitmid(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_MID;
|
||||
AmdParamStruct.AllocationMethod = PostMemDram;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
@ -244,7 +244,7 @@ AGESA_STATUS agesawrapper_amdS3Save(void)
|
|||
|
||||
AmdInterfaceParams.StdHeader.ImageBasePtr = 0;
|
||||
AmdInterfaceParams.StdHeader.HeapStatus = HEAP_SYSTEM_MEM;
|
||||
AmdInterfaceParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdInterfaceParams.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdInterfaceParams.AllocationMethod = PostMemDram;
|
||||
AmdInterfaceParams.AgesaFunctionName = AMD_S3_SAVE;
|
||||
AmdInterfaceParams.StdHeader.AltImageBasePtr = 0;
|
||||
|
@ -278,7 +278,7 @@ AGESA_STATUS agesawrapper_amdinitlate(void)
|
|||
AmdParamStruct.AgesaFunctionName = AMD_INIT_LATE;
|
||||
AmdParamStruct.AllocationMethod = PostMemDram;
|
||||
AmdParamStruct.StdHeader.AltImageBasePtr = 0;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdParamStruct.StdHeader.Func = 0;
|
||||
AmdParamStruct.StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
@ -338,7 +338,7 @@ AGESA_STATUS agesawrapper_amdlaterunaptask(UINT32 Func, UINT32 Data, VOID * Conf
|
|||
memset(&ApExeParams, 0, sizeof(AP_EXE_PARAMS));
|
||||
|
||||
ApExeParams.StdHeader.AltImageBasePtr = 0;
|
||||
ApExeParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) & GetBiosCallout;
|
||||
ApExeParams.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
ApExeParams.StdHeader.Func = 0;
|
||||
ApExeParams.StdHeader.ImageBasePtr = 0;
|
||||
ApExeParams.FunctionNumber = Func;
|
||||
|
|
|
@ -712,7 +712,7 @@ static void amd_readeventlog(AMD_CONFIG_PARAMS *StdHeader)
|
|||
memset(&AmdEventParams, 0, sizeof(EVENT_PARAMS));
|
||||
|
||||
AmdEventParams.StdHeader.AltImageBasePtr = 0;
|
||||
AmdEventParams.StdHeader.CalloutPtr = (CALLOUT_ENTRY) &GetBiosCallout;
|
||||
AmdEventParams.StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
AmdEventParams.StdHeader.Func = 0;
|
||||
AmdEventParams.StdHeader.ImageBasePtr = 0;
|
||||
AmdEventParams.StdHeader.HeapStatus = StdHeader->HeapStatus;
|
||||
|
|
|
@ -49,7 +49,7 @@ AGESA_STATUS agesawrapper_fchs3earlyrestore (void)
|
|||
StdHeader.HeapStatus = HEAP_SYSTEM_MEM;
|
||||
StdHeader.HeapBasePtr = (uintptr_t) GetHeapBase() + 0x10;
|
||||
StdHeader.AltImageBasePtr = 0;
|
||||
StdHeader.CalloutPtr = (CALLOUT_ENTRY) &GetBiosCallout;
|
||||
StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
StdHeader.Func = 0;
|
||||
StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
@ -69,7 +69,7 @@ AGESA_STATUS agesawrapper_fchs3laterestore (void)
|
|||
StdHeader.HeapStatus = HEAP_SYSTEM_MEM;
|
||||
StdHeader.HeapBasePtr = (uintptr_t) GetHeapBase() + 0x10;
|
||||
StdHeader.AltImageBasePtr = 0;
|
||||
StdHeader.CalloutPtr = (CALLOUT_ENTRY) &GetBiosCallout;
|
||||
StdHeader.CalloutPtr = &GetBiosCallout;
|
||||
StdHeader.Func = 0;
|
||||
StdHeader.ImageBasePtr = 0;
|
||||
|
||||
|
|
Loading…
Reference in New Issue