GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/uart: make index parameters unsigned 

The UART index is never negative, so make it unsigned and drop the check
for the index to be non-negative.

BRANCH=zork

Change-Id: I38b5dad87f8af4fbe8ee1d919230efe48f68686c
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45292
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Felix Held 2020-09-11 14:53:03 +02:00
parent c92524d488
commit 8395165eee
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/picasso/include/soc/uart.h
View File

@ -5,9 +5,9 @@
#include <types.h>
void set_uart_config(int idx); /* configure hardware of FCH UART selected by idx */
void set_uart_config(unsigned int idx); /* configure hardware of FCH UART selected by idx */
void clear_uart_legacy_config(void); /* disable legacy I/O decode for FCH UART */
uintptr_t get_uart_base(int idx); /* get MMIO base address of FCH UART */
uintptr_t get_uart_base(unsigned int idx); /* get MMIO base address of FCH UART */
#endif /* __PICASSO_UART_H__ */

8
src/soc/amd/picasso/uart.c
View File

@ -32,9 +32,9 @@ static const struct _uart_info {
} },
};
uintptr_t get_uart_base(int idx)
uintptr_t get_uart_base(unsigned int idx)
{
if (idx < 0 || idx >= ARRAY_SIZE(uart_info))
if (idx >= ARRAY_SIZE(uart_info))
return 0;
return uart_info[idx].base;
@ -45,12 +45,12 @@ void clear_uart_legacy_config(void)
write16((void *)FCH_UART_LEGACY_DECODE, 0);
}
void set_uart_config(int idx)
void set_uart_config(unsigned int idx)
{
uint32_t uart_ctrl;
uint16_t uart_leg;
if (idx < 0 || idx >= ARRAY_SIZE(uart_info))
if (idx >= ARRAY_SIZE(uart_info))
return;
program_gpios(uart_info[idx].mux, 2);