sb/intel/common: Show "Add gigabit ethernet firmware" only for boards that need it

Hide "Add gigabit ethernet firmware" option for boards that do not
use GbE firmware in GbE section.

The option is now hidden by default and can be reenabled on a
per-board basis by selecting MAINBOARD_USES_IFD_GBE_REGION in the
mainboards Kconfig.

The following boards seem to use this:
mb/roda/rv11
mb/ocp/wedge100s
mb/ocp/monolake
mb/lenovo/x230
mb/lenovo/x220
mb/lenovo/x201
mb/lenovo/x200
mb/lenovo/t530
mb/lenovo/t520
mb/lenovo/t430s
mb/lenovo/t430
mb/lenovo/t420s
mb/lenovo/t420
mb/lenovo/t400
mb/kontron/ktqm77
mb/intel/saddlebrook
mb/intel/kblrvp
mb/intel/dg43gt
mb/intel/dcp847ske
mb/intel/coffeelake_rvp
mb/intel/camelbackmountain_fsp
mb/hp/revolve_810_g1
mb/hp/folio_9470m
mb/hp/compaq_8200_elite_sff
mb/hp/8770w
mb/hp/8470p
mb/hp/8460p
mb/hp/2760p
mb/hp/2570p
mb/google/sarien
mb/facebook/watson
mb/compulab/intense_pc
mb/asus/maximus_iv_gene-z

The boards were identified by looking at devicetree.cb, but this
list is possibly still incomplete.

Change-Id: Ibfb07902ad93fe5ff2bd4f869abcf6579f7b5a79
Signed-off-by: Jan Tatje <jan@jnt.io>
Reviewed-on: https://review.coreboot.org/c/30790
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jan Tatje 2019-01-09 20:39:28 +01:00 committed by Patrick Georgi
parent d2abe9314e
commit 83a127a189
34 changed files with 37 additions and 1 deletions

View File

@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS
select SOUTHBRIDGE_INTEL_BD82X6X select SOUTHBRIDGE_INTEL_BD82X6X
select SUPERIO_NUVOTON_NCT6776 select SUPERIO_NUVOTON_NCT6776
select USE_NATIVE_RAMINIT select USE_NATIVE_RAMINIT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -14,6 +14,7 @@ config BOARD_SPECIFIC_OPTIONS
select USE_NATIVE_RAMINIT select USE_NATIVE_RAMINIT
select SUPERIO_SMSC_SIO1007 select SUPERIO_SMSC_SIO1007
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -8,6 +8,7 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select INTEGRATED_UART select INTEGRATED_UART
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -24,6 +24,7 @@ config BOARD_GOOGLE_BASEBOARD_SARIEN
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
select TPM2 select TPM2
select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_EC_REGION
select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_SARIEN
if BOARD_GOOGLE_BASEBOARD_SARIEN if BOARD_GOOGLE_BASEBOARD_SARIEN

View File

@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -34,6 +34,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_SMSC_LPC47N217 select SUPERIO_SMSC_LPC47N217
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_SMSC_LPC47N217 select SUPERIO_SMSC_LPC47N217
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_SMSC_LPC47N217 select SUPERIO_SMSC_LPC47N217
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_NUVOTON_NPCD378 select SUPERIO_NUVOTON_NPCD378
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS
select INTEGRATED_UART if FSP_PACKAGE_DEFAULT select INTEGRATED_UART if FSP_PACKAGE_DEFAULT
select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS
select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP
select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP
select MAINBOARD_USES_IFD_EC_REGION select MAINBOARD_USES_IFD_EC_REGION
select MAINBOARD_USES_IFD_GBE_REGION if !BOARD_INTEL_COFFEELAKE_RVPU
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -11,6 +11,7 @@ config BOARD_SPECIFIC_OPTIONS
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE
select INTEL_INT15 select INTEL_INT15
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_USES_IFD_GBE_REGION
menu "Debugging" menu "Debugging"

View File

@ -34,6 +34,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_I2C_CK505 select DRIVERS_I2C_CK505
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_USES_IFD_GBE_REGION
config VGA_BIOS_ID config VGA_BIOS_ID
string string

View File

@ -16,6 +16,7 @@ config BOARD_SPECIFIC_OPTIONS
select GENERIC_SPD_BIN select GENERIC_SPD_BIN
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM
select INTEL_LPSS_UART_FOR_CONSOLE select INTEL_LPSS_UART_FOR_CONSOLE
select MAINBOARD_USES_IFD_GBE_REGION if BOARD_INTEL_KBLRVP8
config VBOOT config VBOOT
select VBOOT_LID_SWITCH select VBOOT_LID_SWITCH

View File

@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_NUVOTON_NCT6776_COM_A select SUPERIO_NUVOTON_NCT6776_COM_A
select SADDLEBROOK_USES_FSP1_1 select SADDLEBROOK_USES_FSP1_1
select HAVE_CMOS_DEFAULT select HAVE_CMOS_DEFAULT
select MAINBOARD_USES_IFD_GBE_REGION
config SADDLEBROOK_USES_FSP1_1 config SADDLEBROOK_USES_FSP1_1
bool "FSP driver 1.1" bool "FSP driver 1.1"

View File

@ -13,6 +13,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_ANALOG_I2C_HDMI_B select GFX_GMA_ANALOG_I2C_HDMI_B
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -23,6 +23,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_NSC_PC87384 select SUPERIO_NSC_PC87384
select DRIVERS_LENOVO_HYBRID_GRAPHICS select DRIVERS_LENOVO_HYBRID_GRAPHICS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select DRIVERS_LENOVO_HYBRID_GRAPHICS select DRIVERS_LENOVO_HYBRID_GRAPHICS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_TPM1 select MAINBOARD_HAS_TPM1
select DRIVERS_LENOVO_HYBRID_GRAPHICS select DRIVERS_LENOVO_HYBRID_GRAPHICS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -23,6 +23,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -20,6 +20,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS if BOARD_LENOVO_T430S select GFX_GMA_INTERNAL_IS_LVDS if BOARD_LENOVO_T430S
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -19,6 +19,7 @@ config BOARD_LENOVO_BASEBOARD_T520
select MAINBOARD_HAS_TPM1 select MAINBOARD_HAS_TPM1
select DRIVERS_LENOVO_HYBRID_GRAPHICS select DRIVERS_LENOVO_HYBRID_GRAPHICS
select INTEL_GMA_HAVE_VBT if BOARD_LENOVO_T520 select INTEL_GMA_HAVE_VBT if BOARD_LENOVO_T520
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -19,6 +19,7 @@ config BOARD_LENOVO_BASEBOARD_T530
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_NSC_PC87382 select SUPERIO_NSC_PC87382
select DRIVERS_LENOVO_WACOM select DRIVERS_LENOVO_WACOM
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -20,6 +20,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM
select MAINBOARD_HAS_TPM1 select MAINBOARD_HAS_TPM1
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -20,6 +20,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select GFX_GMA_INTERNAL_IS_LVDS select GFX_GMA_INTERNAL_IS_LVDS
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT
select MAINBOARD_USES_IFD_GBE_REGION
# Workaround for EC/KBC IRQ1. # Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE

View File

@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS
select INTEGRATED_UART if FSP_PACKAGE_DEFAULT select INTEGRATED_UART if FSP_PACKAGE_DEFAULT
select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -16,6 +16,7 @@ config BOARD_SPECIFIC_OPTIONS
select MAINBOARD_HAS_TPM1 select MAINBOARD_HAS_TPM1
select DRIVERS_UART_8250IO select DRIVERS_UART_8250IO
select SUPERIO_ITE_IT8528E select SUPERIO_ITE_IT8528E
select MAINBOARD_USES_IFD_GBE_REGION
config VBOOT config VBOOT
select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS

View File

@ -13,6 +13,7 @@ config BOARD_SPECIFIC_OPTIONS
select SERIRQ_CONTINUOUS_MODE select SERIRQ_CONTINUOUS_MODE
select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LIBGFXINIT
select SUPERIO_ITE_IT8783EF if BOARD_RODA_RW11 select SUPERIO_ITE_IT8783EF if BOARD_RODA_RW11
select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View File

@ -107,9 +107,12 @@ config ME_CLEANER_ARGS
depends on USE_ME_CLEANER depends on USE_ME_CLEANER
default "-S" default "-S"
config MAINBOARD_USES_IFD_GBE_REGION
def_bool n
config HAVE_GBE_BIN config HAVE_GBE_BIN
bool "Add gigabit ethernet firmware" bool "Add gigabit ethernet firmware"
depends on HAVE_IFD_BIN depends on HAVE_IFD_BIN && MAINBOARD_USES_IFD_GBE_REGION
help help
The integrated gigabit ethernet controller needs a firmware file. The integrated gigabit ethernet controller needs a firmware file.
Select this if you are going to use the PCH integrated controller Select this if you are going to use the PCH integrated controller