GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/dram/ddr2.c: Fix log messages 

Change 'printk(BIOS_WARNING, "ERROR:' to printk(BIOS_ERR, "'.

Change-Id: Id25bdb1e6b6d7085eff9c2be8263223a91dff061
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61629
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Elyes HAOUAS 2022-02-04 19:34:53 +01:00 committed by Felix Held
parent af382a77d7
commit 83bc408416
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/device/dram/ddr2.c
View File

@ -322,13 +322,13 @@ int spd_decode_ddr2(struct dimm_attr_ddr2_st *dimm, u8 spd[SPD_SIZE_MAX_DDR2])
printram("SPD contains 0x%02x bytes\n", spd_size); printram("SPD contains 0x%02x bytes\n", spd_size);
if (spd_size < 64 || eeprom_size < 64) { if (spd_size < 64 || eeprom_size < 64) {
printk(BIOS_WARNING, "ERROR: SPD to small\n"); printk(BIOS_ERR, "SPD too small\n");
dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED;
return SPD_STATUS_INVALID; return SPD_STATUS_INVALID;
} }
if (spd_ddr2_calc_checksum(spd, spd_size) != spd[63]) { if (spd_ddr2_calc_checksum(spd, spd_size) != spd[63]) {
printk(BIOS_WARNING, "ERROR: SPD checksum error\n"); printk(BIOS_ERR, "SPD checksum error\n");
dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED;
return SPD_STATUS_CRC_ERROR; return SPD_STATUS_CRC_ERROR;
} }
@ -336,8 +336,7 @@ int spd_decode_ddr2(struct dimm_attr_ddr2_st *dimm, u8 spd[SPD_SIZE_MAX_DDR2])
reg8 = spd[62]; reg8 = spd[62];
if ((reg8 & 0xf0) != 0x10) { if ((reg8 & 0xf0) != 0x10) {
printk(BIOS_WARNING, printk(BIOS_ERR, "Unsupported SPD revision %01x.%01x\n",
"ERROR: Unsupported SPD revision %01x.%01x\n",
reg8 >> 4, reg8 & 0xf); reg8 >> 4, reg8 & 0xf);
dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED;
return SPD_STATUS_INVALID; return SPD_STATUS_INVALID;
@ -348,7 +347,7 @@ int spd_decode_ddr2(struct dimm_attr_ddr2_st *dimm, u8 spd[SPD_SIZE_MAX_DDR2])
reg8 = spd[2]; reg8 = spd[2];
printram(" Type : 0x%02x\n", reg8); printram(" Type : 0x%02x\n", reg8);
if (reg8 != 0x08) { if (reg8 != 0x08) {
printk(BIOS_WARNING, "ERROR: Unsupported SPD type %x\n", reg8); printk(BIOS_ERR, "Unsupported SPD type %x\n", reg8);
dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED;
return SPD_STATUS_INVALID; return SPD_STATUS_INVALID;
} }