From 8474f4dc9bfd46bcb111cd3257006057b46d7f08 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 5 Dec 2021 02:45:51 +0100 Subject: [PATCH] soc/intel/tigerlake: Drop unused SataEnable setting `SataEnable` is set by some boards, but it doesn't have any effect since its related FSP option is hooked up to the devicetree state. Thus, drop it. Change-Id: Id645bfcade7ca1d495fb8df538113b3d10392a82 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/59884 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Angel Pons --- src/mainboard/google/deltaur/variants/baseboard/devicetree.cb | 1 - src/mainboard/google/volteer/variants/baseboard/devicetree.cb | 1 - src/soc/intel/tigerlake/chip.h | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index 9ed8fb299e..643bdc1bf7 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -25,7 +25,6 @@ chip soc/intel/tigerlake # FSP configuration register "SaGv" = "SaGv_Disabled" - register "SataEnable" = "1" register "SataMode" = "0" register "SataSalpSupport" = "1" diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index eee29ef2ce..ca9661f09f 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -146,7 +146,6 @@ chip soc/intel/tigerlake register "PcieClkSrcUsage[6]" = "PCIE_CLK_NOTUSED" # Enable SATA - register "SataEnable" = "1" register "SataMode" = "0" register "SataSalpSupport" = "1" register "SataPortsEnable[0]" = "0" diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h index e729e8c0ee..09c8db1caf 100644 --- a/src/soc/intel/tigerlake/chip.h +++ b/src/soc/intel/tigerlake/chip.h @@ -215,7 +215,6 @@ struct soc_intel_tigerlake_config { uint8_t SlowSlewRate; /* SATA related */ - uint8_t SataEnable; uint8_t SataMode; uint8_t SataSalpSupport; uint8_t SataPortsEnable[8];