GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd: Throw an error if FWM_POSITION_INDEX is empty 

The empty string causes an undetectable build error.

Filter out the board which doesn't define this variable.
A great odds that the reason is the board doesn't set a
valid ROM size.

Change-Id: Iade1961460285acdec245c553c7b84014c30c267
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49855
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Zheng Bao 2021-01-23 10:09:00 +08:00 committed by Felix Held
parent 3765b50374
commit 8516c219ce
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/amd/cezanne/Makefile.inc
View File

@ -45,6 +45,9 @@ MAINBOARD_BLOBS_DIR:=$(top)/3rdparty/blobs/mainboard/$(MAINBOARDDIR)
# | | PSPDIR ADDR | BIOSDIR ADDR | # | | PSPDIR ADDR | BIOSDIR ADDR |
# +-----------+---------------+----------------+ # +-----------+---------------+----------------+
$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\
$(error Invalid AMD firmware position index. Check if the board sets a valid ROM size))
CEZANNE_FWM_POSITION=$(call int-add, \ CEZANNE_FWM_POSITION=$(call int-add, \
$(call int-subtract, 0xffffffff \ $(call int-subtract, 0xffffffff \
$(call int-shift-left, \ $(call int-shift-left, \

3
src/soc/amd/picasso/Makefile.inc
View File

@ -84,6 +84,9 @@ MAINBOARD_BLOBS_DIR:=$(top)/3rdparty/blobs/mainboard/$(MAINBOARDDIR)
# | | PSPDIR ADDR | BIOSDIR ADDR | # | | PSPDIR ADDR | BIOSDIR ADDR |
# +-----------+---------------+----------------+ # +-----------+---------------+----------------+
$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\
$(error Invalid AMD firmware position index. Check if the board sets a valid ROM size))
PICASSO_FWM_POSITION=$(call int-add, \ PICASSO_FWM_POSITION=$(call int-add, \
$(call int-subtract, 0xffffffff \ $(call int-subtract, 0xffffffff \
$(call int-shift-left, \ $(call int-shift-left, \