GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tigerlake: Fix unresolved symbol CDW1 error 

The dmesg shows unresolved symbol CDW1 with AE_NOT_FOUND error after
booting to kernel. Fix the error by properly creating the buffer field
CDW1 to cover all errors scenarios.

BUG=b:140645231
TEST=Verified no AE_NOT_FOUND error related to \_SB.OSC.CDW1.

Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: Ibfe677f87736ce1930e06b9cd649791977116012
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42693
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
John Zhao 2020-06-22 09:30:47 -07:00 committed by Patrick Georgi
parent fac2893584
commit 8528867088
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/intel/tigerlake/acpi/tcss.asl
View File

@ -159,13 +159,14 @@ Scope (\_SB)
* control of the respectively capabilities or features. * control of the respectively capabilities or features.
*/ */
Name (CTRL, 0) /* Control field value */ Name (CTRL, 0) /* Control field value */
CreateDWordField (Arg3, 0, CDW1)
If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) { If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) {
CreateDWordField(Arg3, 0, CDW1) CreateDWordField (Arg3, 2, CDW3)
CreateDWordField(Arg3, 2, CDW3)
CTRL = CDW3 CTRL = CDW3
If (Arg1 != REVISION_ID) { If (Arg1 != REVISION_ID) {
CDW1 |= UNRECOGNIZED_REVISION CDW1 |= UNRECOGNIZED_REVISION
Return (Arg3)
} }
CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING | CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING |
INTER_DOMAIN_USB4_INTERNET_PROTOCOL INTER_DOMAIN_USB4_INTERNET_PROTOCOL