nb/amd/amdfam10: Work around sporadic lockups when CC6 enabled

The silicon in control of CC6 appears to contain minor bugs
and / or deviations from the BKDG; through trial and error
it was found that these issues can be worked around by reserving
the entire possible CC6 save region, regardless of currently
installed node count.

Change-Id: If31140651f25f9c524a824b2da552ce3690eae18
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/12054
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Timothy Pearson 2015-08-20 15:53:25 -05:00 committed by Martin Roth
parent 4d5317e5a4
commit 8528e39fba
1 changed files with 14 additions and 0 deletions

View File

@ -810,6 +810,20 @@ static void amdfam10_domain_read_resources(device_t dev)
else
qword = 0x1000000;
/* FIXME
* The BKDG appears to be incorrect as to the location of the CC6 save region
* lower boundary on non-interleaved systems, causing lockups on attempted write
* to the CC6 save region.
*
* For now, work around by allocating the maximum possible CC6 save region size.
*
* Determine if this is a BKDG error or a setup problem and remove this warning!
*/
qword = (0x1 << 27);
max_range_limit = (((uint64_t)(pci_read_config32(get_node_pci(max_node, 1), 0x124) & 0x1fffff)) << 27) - 1;
printk(BIOS_INFO, "Reserving CC6 save segment base: %08llx size: %08llx\n", (max_range_limit + 1), qword);
/* Reserve the CC6 save segment */
reserved_ram_resource(dev, 8, (max_range_limit + 1) >> 10, qword >> 10);
}