From 852ab7500565c7c5ff256b32c6373d38da1c8866 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Thu, 10 Nov 2022 14:51:49 +0100 Subject: [PATCH] drivers/ipmi/ocp: Fix building with clang Fix the following warning: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand] Change-Id: I9a2f03a0e05088a780ce1e829859421b461032ca Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/69437 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/drivers/ipmi/ocp/ipmi_sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/ipmi/ocp/ipmi_sel.c b/src/drivers/ipmi/ocp/ipmi_sel.c index b10755fd97..f7605ec572 100644 --- a/src/drivers/ipmi/ocp/ipmi_sel.c +++ b/src/drivers/ipmi/ocp/ipmi_sel.c @@ -105,7 +105,7 @@ __weak uint8_t get_blade_id(void) { struct ipmi_config_rsp rsp = {.slot_id = UINT8_MAX}; - if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE) { + if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE != 0) { if (ipmi_get_board_config(CONFIG_BMC_KCS_BASE, &rsp) != CB_SUCCESS) return UINT8_MAX; }