From 856a3f4a3c01fb2de022cec3e4c8e95eeeeb4345 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 16 Oct 2022 13:52:45 -0500 Subject: [PATCH] mb/google/sarien: Fix WiFi SAR options SAR-related Kconfigs are only used by ChromeOS, and should be guarded properly as such (as most other boards do). TEST=build sarien w/o CONFIG_CHROMEOS, verify SAR-related Kconfigs not selected. Change-Id: I424033e087bc37c651a922273718fc229b720448 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/68456 Reviewed-by: Angel Pons Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/sarien/Kconfig | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 37c72ad663..524025369d 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -16,14 +16,12 @@ config BOARD_GOOGLE_BASEBOARD_SARIEN select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_EC_REGION - select SAR_ENABLE select SMBIOS_SERIAL_FROM_VPD if VPD select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_DISABLE select SOC_INTEL_WHISKEYLAKE select SPD_READ_BY_WORD select TPM_GOOGLE_CR50 - select USE_SAR config BOARD_GOOGLE_ARCADA select BOARD_GOOGLE_BASEBOARD_SARIEN @@ -37,6 +35,13 @@ config BOARD_GOOGLE_SARIEN if BOARD_GOOGLE_BASEBOARD_SARIEN +config CHROMEOS_WIFI_SAR + bool "Enable SAR options for ChromeOS build" + depends on CHROMEOS + default y if CHROMEOS + select SAR_ENABLE + select USE_SAR + config DISABLE_HECI1_AT_PRE_BOOT default y