From 856ba070dd3f4a1ae2b40c89d29a52de40ff844c Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 24 Sep 2023 02:14:51 +0200 Subject: [PATCH] mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: If6b666478e15a8e843b50b60be490593349240bd Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/78132 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/mainboard/intel/mtlrvp/Kconfig | 2 ++ src/mainboard/intel/mtlrvp/Kconfig.name | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 8a5908519d..f225aa5aaa 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -26,10 +26,12 @@ config BOARD_INTEL_MTLRVP_P config BOARD_INTEL_MTLRVP_P_EXT_EC select BOARD_EXT_EC_SPECIFIC_OPTIONS + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_INTEL_MTLRVP_P_MCHP select BOARD_EXT_EC_SPECIFIC_OPTIONS select EC_GOOGLE_CHROMEEC_MEC + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_EXT_EC_SPECIFIC_OPTIONS def_bool n diff --git a/src/mainboard/intel/mtlrvp/Kconfig.name b/src/mainboard/intel/mtlrvp/Kconfig.name index afba1efda0..9f61aff142 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig.name +++ b/src/mainboard/intel/mtlrvp/Kconfig.name @@ -3,8 +3,6 @@ config BOARD_INTEL_MTLRVP_P config BOARD_INTEL_MTLRVP_P_EXT_EC bool "Meteorlake-P RVP with Chrome EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_INTEL_MTLRVP_P_MCHP bool "Meteorlake-P RVP with Microchip EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON