From 85b2b27e3309fcd783b825682dd715bee089ad01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 10 Jan 2017 06:25:57 +0200 Subject: [PATCH] SPI: Fix command-response behavior MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix SPI flash ops regressions after commit: c2973d1 spi: Get rid of SPI_ATOMIC_SEQUENCING When spi_flash_cmd() is called with argument response==NULL, only send out command without reading back the response. Change-Id: I28a94f208b4a1983d45d69d46db41391e267891d Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/18082 Tested-by: build bot (Jenkins) Reviewed-by: Timothy Pearson Tested-by: Raptor Engineering Automated Test Stand Reviewed-by: Aaron Durbin Reviewed-by: Ronald G. Minnich --- src/drivers/spi/spi_flash.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index a0e310554a..95362f2618 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -49,11 +49,14 @@ static int do_spi_flash_cmd(const struct spi_slave *spi, const void *dout, [1] = { .dout = NULL, .bytesout = 0, .din = din, .bytesin = bytes_in }, }; + size_t count = ARRAY_SIZE(vectors); + if (!bytes_in) + count = 1; if (spi_claim_bus(spi)) return ret; - if (spi_xfer_vector(spi, vectors, ARRAY_SIZE(vectors)) == 0) + if (spi_xfer_vector(spi, vectors, count) == 0) ret = 0; spi_release_bus(spi);