GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/ifdtools: Make EC region readable to BIOS/CPU 

Allow EC region to be readable by BIOS/CPU so that flashrom
can read it.

BUG=b:123199222
TEST=Build coreboot with CONFIG_LOCK_MANAGEMENT_ENGINE set,
run firmware_LockedME test.

Change-Id: I306c74a0893355e57632a22a712b1f4fdaa19306
Signed-off-by: Bora Guvendik <bora.guvendik@intel.com>
Reviewed-on: https://review.coreboot.org/c/31377
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
This commit is contained in:
Bora Guvendik 2019-02-12 13:07:45 -08:00 committed by Patrick Georgi
parent 32bc1dc531
commit 85ea91ae3c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/ifdtool/ifdtool.c
View File

@ -969,8 +969,8 @@ static void lock_descriptor(const char *filename, char *image, int size)
case PLATFORM_CNL: case PLATFORM_CNL:
case PLATFORM_ICL: case PLATFORM_ICL:
case PLATFORM_SKLKBL: case PLATFORM_SKLKBL:
/* CPU/BIOS can read descriptor, BIOS and GbE. */ /* CPU/BIOS can read descriptor, BIOS, EC and GbE. */
fmba->flmstr1 |= 0xb << rd_shift; fmba->flmstr1 |= 0x10b << rd_shift;
/* CPU/BIOS can write BIOS and Gbe. */ /* CPU/BIOS can write BIOS and Gbe. */
fmba->flmstr1 |= 0xa << wr_shift; fmba->flmstr1 |= 0xa << wr_shift;
/* ME can read descriptor, ME and GbE. */ /* ME can read descriptor, ME and GbE. */