From 865dd085f6aaef17072184e5f0024d7eeffebafd Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 10 Apr 2022 10:52:49 +0200 Subject: [PATCH] superio/smsc/sch5545: Drop `_PRS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. In addition, drop `IGNORE_IASL_MISSING_DEPENDENCY` from the only mainboard using the SCH5545 code, `dell/snb_ivb_workstations`. Change-Id: Ic462bd3dfa287744d4f733561de81c09c1c397e6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/63522 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- .../dell/snb_ivb_workstations/Kconfig | 3 --- src/superio/smsc/sch5545/acpi/superio.asl | 25 ------------------- 2 files changed, 28 deletions(-) diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig b/src/mainboard/dell/snb_ivb_workstations/Kconfig index 8416a0f31f..788f5a1d4c 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig @@ -20,9 +20,6 @@ config BOARD_DELL_SNB_IVB_WORKSTATIONS if BOARD_DELL_SNB_IVB_WORKSTATIONS -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config MAINBOARD_DIR default "dell/snb_ivb_workstations" diff --git a/src/superio/smsc/sch5545/acpi/superio.asl b/src/superio/smsc/sch5545/acpi/superio.asl index 97303c29fa..20278b4745 100644 --- a/src/superio/smsc/sch5545/acpi/superio.asl +++ b/src/superio/smsc/sch5545/acpi/superio.asl @@ -232,22 +232,6 @@ Device(SIO1) { ) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0x00, 0x00) - { - FixedIO ( - 0x0060, // Address - 0x01, - ) - FixedIO ( - 0x0064, // Address - 0x01, - ) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) Method (_PSW, 1, NotSerialized) // _PSW: Power State Wake { KBFG = Arg0 @@ -268,15 +252,6 @@ Device(SIO1) { IRQ (Edge, ActiveHigh, Exclusive) {12} }) - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0x00, 0x00) - { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) - Method (_PSW, 1, NotSerialized) { MSFG = Arg0