GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/ironlake: Drop some unused function parameters 

Some of the HECI functions do not need raminfo at all.

Change-Id: If0720fa87e5e18820db77a1b61bcdb42ecc538fb
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45362
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons 2020-09-14 18:48:59 +02:00
parent d02f3303d9
commit 8690746efb
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/northbridge/intel/ironlake/raminit.c
View File

@ -1691,7 +1691,7 @@ send_heci_message(u8 *msg, int len, u8 hostaddress, u8 clientaddress)
/* FIXME: Add timeout. */ /* FIXME: Add timeout. */
static int static int
recv_heci_packet(struct raminfo *info, struct mei_header *head, u32 *packet, recv_heci_packet(struct mei_header *head, u32 *packet,
u32 *packet_size) u32 *packet_size)
{ {
union { union {
@ -1736,7 +1736,7 @@ recv_heci_packet(struct raminfo *info, struct mei_header *head, u32 *packet,
/* FIXME: Add timeout. */ /* FIXME: Add timeout. */
static int static int
recv_heci_message(struct raminfo *info, u32 *message, u32 *message_size) recv_heci_message(u32 *message, u32 *message_size)
{ {
struct mei_header head; struct mei_header head;
int current_position; int current_position;
@ -1746,7 +1746,7 @@ recv_heci_message(struct raminfo *info, u32 *message, u32 *message_size)
u32 current_size; u32 current_size;
current_size = *message_size - current_position; current_size = *message_size - current_position;
if (recv_heci_packet if (recv_heci_packet
(info, &head, message + (current_position >> 2), (&head, message + (current_position >> 2),
&current_size) == -1) &current_size) == -1)
break; break;
if (!current_size) if (!current_size)
@ -1796,7 +1796,7 @@ static void send_heci_uma_message(struct raminfo *info)
send_heci_message((u8 *) & msg, sizeof(msg), 0, 7); send_heci_message((u8 *) & msg, sizeof(msg), 0, 7);
reply_size = sizeof(reply); reply_size = sizeof(reply);
if (recv_heci_message(info, (u32 *) & reply, &reply_size) == -1) if (recv_heci_message((u32 *) & reply, &reply_size) == -1)
return; return;
if (reply.command != (MKHI_SET_UMA | (1 << 7))) if (reply.command != (MKHI_SET_UMA | (1 << 7)))